Repository navigation
refactor: remove the tmux overlay experiment - #419
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes what was left of the tmux overlay experiment. It could only be turned on with a hidden
defaults writekey, and no Settings UI reached it. The default behavior does not change: attention flashes still run on the surface itself, and the unread ring still shows.About 1,000 lines go, roughly a third of them tests.
Review order
Sources/Panels/TerminalPanel.swift:triggerFlashkeeps only the.surfacepath.Sources/Workspace.swift,Workspace+Bonsplit.swift,Workspace+Surfaces.swift: these remove the overlay-only published fields and theconfigureTerminalPanelhook.didChangeGeometrystill schedules terminal geometry and focus reconcile. It no longer republishes a layout snapshot on every resize.Sources/WorkspaceContentView.swift,WindowOverlayControllers.swift,ContentView.swift: these remove the overlay view, model, window controller and rect helpers..bonsplitPanetarget. Mixed tests keep their unread and focus assertions.TmuxWorkspacePaneOverlayTestsis renamedAppIconAndFlashStyleTestsfor the tests that remain.docs/removed/tmux-active-pane-overlay.mdnow covers the whole experiment and has a restore line.Test plan