Repository navigation
fix: review fixes 01-1.1, 1.2, 03-3.1, 3.2, 3.3, 3.4, 3.9 - #77
Merged
Merged
Conversation
01-1.1 a fund's holdings count as loaded only when every page loaded: a failed or cancelled load is retried on the next selection instead of leaving partial data marked complete 01-1.2 fetchJson aborts after 30 s 03-3.2 sheet pages are appended in place instead of concat copies
03-3.1 Holdings and History render in 300-row windows that grow on scroll 03-3.3 sort keys are computed once per row, not per comparison 03-3.4 one delegated listener per event type; Watchlist appends chunks 03-3.9 sheet row objects are built once and reused as pages arrive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fixes from the 2026-10-11 code review (plans 01 and 03), applied with
patch-brands-critical.pyandpatch-brands-perf.py; every anchor matched exactly onceCommits
fix: 01-1.1+1.2+03-3.2 critical fixesfetchJsonaborts after 30 s (headers and body)concatcopies (thetableViewcache still invalidates: its signature carries the row count)perf: 03 sheet window, sort keys, delegation, incremental sheetView21-Aug-2026dates, then numeric collation; empty values last)Checks run
bun install --frozen-lockfile,bun test,bun build --target=bun src/main.tsx --outfile=/dev/null,bun run build,git diff --check.claude/tools/etfs/tc/check.sh: no type errorscolumns-uitest.ts,categories-uitest.ts: all0 failed; console errors: noneManual checks still worth doing
WisdomTree results: 44pass unit tests; brand-uitest, columns-uitest, categories-uitest 0 failed; Playwright check 16 passed, 0 failed (UNIY AGGY DDWM, 6159 holdings rows)