Repository navigation
nfs: deny any concurrent access to a file opened for write - #8255
Merged
Merged
Conversation
Motivation:
dCache design flow allows concurrent writes for a file as long as it
in `create-only` mode. Such a flow typically ends with a two replicas of
a file with a same pnfsid, but different contents:
```
$ python
>>> f1 = open("file.txt", "w")
>>> f2 = open("file.txt", "w")
>>> f1.write("aaaa")
4
>>> f2.write("bbb")
3
>>> f1.close()
>>> f2.close()
```
Modification:
Enforce share-deny for files opened for write.
Result:
```
$ python
>>> f1 = open("file.txt", "w")
>>> f2 = open("file.txt", "w")
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
f2 = open("file.txt", "w")
PermissionError: [Errno 13] Permission denied: 'file.txt'
>>> f2 = open("file.txt", "r")
Traceback (most recent call last):
File "<python-input-2>", line 1, in <module>
f2 = open("file.txt", "r")
PermissionError: [Errno 13] Permission denied: 'file.txt'
```
Acked-by: Marina Sahakyan
Target: master, 12.0, 11.2
Require-book: no
Require-notes: yes
(cherry picked from commit 5bd6b33)
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
dCache design flow allows concurrent writes for a file as long as it in
create-onlymode. Such a flow typically ends with a two replicas of a file with a same pnfsid, but different contents:Modification:
Enforce share-deny for files opened for write.
Result:
Acked-by: Marina Sahakyan
Target: master, 12.0, 11.2
Require-book: no
Require-notes: yes
(cherry picked from commit 5bd6b33)