Repository navigation
Conversation
The validator walked marketplace.json entries only, so a directory with a .cursor-plugin/plugin.json that no entry references (forgotten listing, or a typo in source) passed CI and never reached the marketplace. Walk the repo root and third_party/ for plugin directories and fail for each one that is not a listed source. main has 102 listed and 0 unlisted today, so this is an error from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Piece 3d of #531, the last one.
scripts/validate-plugins.mjsiteratedmarketplace.pluginsand validated each referenced directory, but nothing walked the repo the other way. A plugin directory that no entry references (a forgotten listing, or asourcetypo that happens to point at a sibling) passed with "All plugins validated successfully." and never reached the marketplace.New step 3: collect
resolve(root, entry.source)for every entry, walk the repo root andthird_party/for non-dot directories that contain.cursor-plugin/plugin.json, andfail()for each one not in that set:On current
mainthere are 102 listed sources and 0 unlisted directories, so this is an error from day one rather than a warning (unlike the frontmatter check in #618, which had existing offenders).Verification
node scripts/validate-plugins.mjson this branch againstmain:All plugins validated successfully.zz-unlisted/.cursor-plugin/plugin.jsonin the root andthird_party/zz-vendor/.cursor-plugin/plugin.json: oneUnlisted pluginerror each, exit 1.Separate from #618 on purpose so that PR does not grow after opening; both touch this file, so whichever lands second needs a trivial rebase (also #582).
Refs #531.