Repository navigation
Conversation
…nstall with npm ci
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Piece 2 of #531. The validate workflow runs
npm install --no-save ajv ajv-formatson every job, so each run resolves whateverajvandajv-formatsare current. A major release of either (schema draft handling, format defaults) can turn CI red or, worse, quietly change what the schema check accepts, with no commit in this repo to bisect.What
package.jsonat the repo root,private, withajv8.20.0 andajv-formats3.0.1 as exactdevDependenciesand avalidatescript. The plugins themselves have no runtime dependencies; this is repo tooling only.package-lock.json(7 packages)..github/workflows/validate-plugins.yml:npm ciwith the npm cache enabled insetup-node,npm run validate, andscripts/**, the two package files and the workflow itself added to thepaths:trigger so a change to the validator or its dependencies runs the job. (ci: validate every PR and check declared plugin component paths exist #582 drops the filter entirely; whichever lands second has a two-line rebase.)Checked
rm -rf node_modules && npm ci && npm run validateon currentmain:All plugins validated successfully.Local run with the same versions matches what the workflow installs today, so no behaviour change in the check itself.Refs #531.