Repository navigation
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Piece 3b of #531: the validator never opens a
SKILL.md, so a skill can ship without anameordescription, with a name that does not match its folder, or with a description over the 1024-character cap, and CI stays green. The rules come from the skills docs (cursor.com/docs/context/skills, Frontmatter fields):nameanddescriptionrequired;nameis lowercase letters, digits and hyphens and must match the parent folder.What
scripts/validate-plugins.mjsnow walks each plugin's skills directory (the declaredskillspath orskills/by default, non-glob) and, for every<skill>/SKILL.md, parses the frontmatter with a small YAML-subset reader (top-levelkey: value, quoted scalars,>/|block scalars) and checks:name; missingdescription.namenot kebab-case or not equal to the folder name;descriptionlonger than 1024 characters.Warnings instead of errors for the last two because
maincurrently has five such cases and I did not want this PR to turn CI red or to carry unrelated content edits:#530 fixes the first, #596 the two pstack ones; the two
third_partynames are for their owners. Once those land, flippingwarn(tofail(on the two rules is a two-line follow-up.Checked
node scripts/validate-plugins.mjson currentmain: 0 errors, the 5 warnings above, exit 0.description:from a skill fails withmissing "description" in SKILL.md frontmatter; replacing the file with plain markdown fails withhas no YAML frontmatter.description: >-with indented continuation, as inmake-bot-ui) parse to a single line and are measured correctly.Independent of #582 in intent (that one checks declared paths exist); both touch this file, so whichever lands second needs a trivial rebase.
Refs #531.