Repository navigation
build --format json: kinds, properties and named exits beyond ROM - #25
Merged
Merged
Conversation
…xits ROM cannot hold build --format json writes the area as area-reader prints it. A header, room, mob, object or exit may name a kind, give it parameters with 'with', and set properties; an exit whose name is not a compass direction is a one-sided named exit. The ROM part is still rendered, parsed back and compared. --format rom refuses a source that uses any of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
area-reader build --format jsonwrites the area as the JSON the reader prints, in place of the.arefile, so a source directory can say things a ROM area file has no place for.kind,withandpropertieson the header, a room, a mob, an object or an exit. They appear under the same names on the record in the JSON.--format rom(the default) refuses a source that uses any of this and names the first place it does.For a plain source the JSON equals what
area-reader AREA.areprints for the built area (tested on the example area).Not in this PR:
lint,walkandunbuilddo not read the JSON, and no registry of kinds exists, so any slug is accepted.Tests: 1722 passed, 11 of them new.
ruff checkclean.