Repository navigation
Name ROM detect affect bits as ROM does - #23
Merged
Merged
Conversation
AFFECTED_BY named bits C-G and I EVIL, INVIS, MAGIC, HIDDEN, GOOD and FIRE. In ROM's merc.h they are AFF_DETECT_EVIL, AFF_DETECT_INVIS, AFF_DETECT_MAGIC, AFF_DETECT_HIDDEN, AFF_DETECT_GOOD and AFF_FAERIE_FIRE. A consumer reading INVIS or HIDDEN took a mob that can see invisible things for one that is invisible (Midgaard's Hassan, vnum 3011).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROM's
AFFECTED_BYbits C to G and I were namedEVIL,INVIS,MAGIC,HIDDEN,GOOD,FIRE.merc.hcalls themAFF_DETECT_EVIL,AFF_DETECT_INVIS,AFF_DETECT_MAGIC,AFF_DETECT_HIDDEN,AFF_DETECT_GOOD,AFF_FAERIE_FIRE. Bit B isINVISIBLEand Q isHIDE, so a consumer that sawINVIS|HIDDENon Midgaard's Hassan (lettersCDFJVZ) made him invisible and hidden when he only detects those.This changes the names in
as_dict()output for ROM mobs'affected_by. Nothing else in the repository used the old names. Suite: 1242 passed.