Repository navigation
Fix shared-file symlink direction in atomic deployment example - #791
Open
kevinsleegerslameco wants to merge 1 commit into
Open
kevinsleegerslameco wants to merge 1 commit into
kevinsleegerslameco wants to merge 1 commit into
Conversation
👷 Deploy request for craft-docs pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atomic deployment example creates the persistent-file links the wrong way round.
ln -s TARGET LINK_NAMEputs the link at the second path, socreates a link inside
shared/pointing at the release, instead of a link inside the release pointing atshared/. The release then has no.envand noweb/uploads.This swaps the arguments on both lines, matching the tree diagram right below the example (
.env → /var/www/shared/.env,uploads/ → /var/www/shared/web/uploads/).