You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added a hideWrapBanner row (boolean, default false) after hideBridgeInfo in docs/cow-protocol/tutorials/widget/widget.md.
Why
When a user sells native ETH, the widget shows a "Wrap your ETH and use the classic WETH experience!" banner. Lido's integration doesn't support wrapping and asked for a way to hide it.
Risks
The parameter only takes effect once a widget build that includes cowswap#8461 is deployed, and it won't be in the TypeScript types until the next @cowprotocol/widget-lib release after 4.6.0. If this lands first, the docs will list an option that doesn't work yet.
To test
Open /cow-protocol/tutorials/widget#cowswapwidgetparams
Make sure the table has a hideWrapBanner row right after hideBridgeInfo, and the table still renders normally
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 6b4e2359-f388-4267-b0b9-6066439240ba
📥 Commits
Reviewing files that changed from the base of the PR and between b5e4e68 and 79ab06b.
📒 Files selected for processing: 1
docs/cow-protocol/tutorials/widget/widget.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The widget tutorial now documents the hideWrapBanner option. It describes hiding the native-token wrapping suggestion below the Swap button when selling the native token.
No documentation defect is established. Confirm the stated widget-release prerequisite before publishing the option to integrations.
Pre-merge checks: 5
Check name
Status
Explanation
Description check
The description provides the change, reason, implementation details, risks, testing steps, preview URL, and related issue. It does not use the template headings exactly, but it contains the required i…
Title check
The title clearly identifies the main change: adding the hideWrapBanner widget configuration option.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description provides the change, reason, implementation details, risks, testing steps, preview URL, and related issue. It does not use the template headings exactly, but it contains the required information and is complete.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the new
hideWrapBannerwidget parameter from cowprotocol/cowswap#8461 in theCowSwapWidgetParamstable.Fixes FE-979
Details
What changed
hideWrapBannerrow (boolean, defaultfalse) afterhideBridgeInfoindocs/cow-protocol/tutorials/widget/widget.md.Why
Risks
@cowprotocol/widget-librelease after 4.6.0. If this lands first, the docs will list an option that doesn't work yet.To test
/cow-protocol/tutorials/widget#cowswapwidgetparamshideWrapBannerrow right afterhideBridgeInfo, and the table still renders normallyPreview URLs
Self-checks
Summary by CodeRabbit
hideWrapBanneroption for hiding the native-token wrapping banner below the Swap button when selling a native token.