Skip to content

test(Table): drop explicit zoneless provider, unique ancestor selector #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xidedix merged 2 commits into from
Oct 19, 2026
Merged

test(Table): drop explicit zoneless provider, unique ancestor selector #308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7497480
test(Table): drop explicit provideZonelessChangeDetection
xidedix Oct 19, 2026
c31efa3
test(Table): give the ancestor test component its own selector
xidedix Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/coreui-angular/src/lib/table/table.directive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
ErrorHandler,
inject,
inputBinding,
provideZonelessChangeDetection,
Renderer2,
RendererFactory2,
RendererType2,
Expand Down Expand Up @@ -55,6 +54,7 @@ class OutletTestComponent {
}

@Component({
selector: 'c-test-table-ancestor',
imports: [TableDirective],
template: `<section>
@if (show()) {
Expand Down Expand Up @@ -350,7 +350,7 @@ describe('TableDirective with a renderer that defers removals to the end of chan

describe('TableDirective in an application being destroyed', () => {
it('should not throw', async () => {
const appRef = await createApplication({ providers: [provideZonelessChangeDetection()] });
const appRef = await createApplication();
const hostElement = document.body.appendChild(document.createElement('div'));
try {
const componentRef = createComponent(ToggleTestComponent, { environmentInjector: appRef.injector, hostElement });
Expand Down
Loading