Skip to content

test: delete every test that asserts CSS or animation implementation - #626

Merged
omridevk merged 1 commit into
mainfrom
delete-css-tests
Oct 30, 2026
Merged

omridevk merged 1 commit into
mainfrom
delete-css-tests

Conversation

@omridevk

Copy link
Copy Markdown
Contributor

Summary

Deletes every test case that asserts CSS values or animation internals (toHaveCSS, toHaveStyle, getComputedStyle reads, getAnimations() keyframes, inline style property reads). These pin tests to how a style is implemented and to animation timing, and they are the source of the recent CI flakes (brand lockup antenna flick on #623, robot fab hover on #622). Behaviour tests in the same files stay untouched.

Files deleted outright: host-skin.it.test.ts, host-scheme.it.test.ts, collapsible-thread-perf.browser.test.tsx, reduced-motion.it.test.ts, streamed-word-animation.browser.test.tsx, both brand *-reduced-motion.browser.test.tsx files with their two vitest projects. Trimmed: trace-rail.browser.test.tsx (22 to 3), robot-fab.it.test.ts (5 to 2), fab-mascot.it.test.ts, fab-drag-snap.it.test.ts, mascot wrapper tests, dialog, tooltip-icon-button, page-tools, two streamdown story play functions, the brand lockup antenna-flick tests.

Cleanup that followed: unused helpers and fixtures, the htmlAttributes option of the embed hostPage helper, the @conciv/browser-fixture devDependency of @conciv/ui-kit-system (its only user was the deleted reduced-motion test), brand tsconfig entries.

Kept on purpose: the calm perf gate's settleMotion wait on getAnimations() in apps/conciv/test/helpers/calm-assertions.ts (a settle step before measuring drift, not a CSS assertion) and setup-only style.cssText assignments.

Test plan

  • typecheck: embed, ui-kit-chat, ui-kit-system, mascot, brand, solid-streamdown, extension-page, site (47 tasks)
  • every touched test file run headless: 124 tests pass across ui-kit-chat, ui-kit-system, mascot, brand, extension-page, embed Playwright, site, storybook
  • fallow audit no introduced dead code; check-changesets --require-coverage exit 0

🤖 Generated with Claude Code

Removes test cases asserting toHaveCSS, toHaveStyle, computed styles,
getAnimations or inline style values, plus the helpers, vitest projects,
tsconfig entries and the ui-kit-system browser-fixture devDependency that
only those tests used.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 420af89e-af7b-490c-8a65-357398e2902b
Commits

Reviewing files that changed from the base of the PR and between 23c7842 and 7b75064.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 27
  • .changeset/delete-css-tests.md
  • apps/site/test/robot-fab.it.test.ts
  • packages/brand/tests/browser/lockup-dom.ts
  • packages/brand/tests/browser/react-lockup-reduced-motion.browser.test.tsx
  • packages/brand/tests/browser/react-lockup.browser.test.tsx
  • packages/brand/tests/browser/solid-lockup-reduced-motion.browser.test.tsx
  • packages/brand/tests/browser/solid-lockup.browser.test.tsx
  • packages/brand/tsconfig.json
  • packages/brand/tsconfig.react.json
  • packages/brand/vitest.config.ts
  • packages/embed/tests/e2e/fab-drag-snap.it.test.ts
  • packages/embed/tests/e2e/fab-mascot.it.test.ts
  • packages/embed/tests/e2e/host-scheme.it.test.ts
  • packages/embed/tests/e2e/host-skin.it.test.ts
  • packages/embed/tests/helpers/host.ts
  • packages/extensions/page/test/page-tools.browser.test.tsx
  • packages/mascot/tests/browser/react-wrapper.browser.test.tsx
  • packages/mascot/tests/browser/solid-wrapper.browser.test.tsx
  • packages/solid-streamdown/src/streamdown.stories.tsx
  • packages/solid-streamdown/test/streamed-word-animation.browser.test.tsx
  • packages/ui-kit-chat/test/collapsible-thread-perf.browser.test.tsx
  • packages/ui-kit-chat/test/thread-trace-rail.browser.test.tsx
  • packages/ui-kit-chat/test/trace-rail.browser.test.tsx
  • packages/ui-kit-system/package.json
  • packages/ui-kit-system/test/dialog.browser.test.tsx
  • packages/ui-kit-system/test/reduced-motion.it.test.ts
  • packages/ui-kit-system/test/tooltip-icon-button.browser.test.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The removed tests leave page_setstyle execution, launcher no-drift behavior after returning to its starting position, and the robot’s stop-click behavior without functional coverage.

3 open issues
1 file not reviewed
What changed in this PR

This PR removes CSS-value and animation-internals assertions across the monorepo to reduce implementation coupling and CI flakes, including the brand and robot-launcher cases discussed in #623 and #622.

Changes:

  • Deletes dedicated styling and animation suites and trims mixed browser tests.
  • Removes unused fixtures, helpers, a development dependency, and brand test configuration.
  • Adds a changeset for the test cleanup.
File Description
packages/​ui-kit-system/​test/​tooltip-icon-button.browser.test.tsx Removes tooltip positioning assertions.
packages/​ui-kit-system/​test/​reduced-motion.it.test.ts Deletes animation-based reduced-motion tests.
packages/​ui-kit-system/​test/​dialog.browser.test.tsx Removes backdrop-filter assertion.
packages/​ui-kit-system/​package.json Removes unused browser-fixture dependency.
packages/​ui-kit-chat/​test/​trace-rail.browser.test.tsx Trims rail styling and animation tests.
packages/​ui-kit-chat/​test/​thread-trace-rail.browser.test.tsx Removes running-connector styling test.
packages/​ui-kit-chat/​test/​collapsible-thread-perf.browser.test.tsx Deletes collapse-animation implementation tests.
packages/​solid-streamdown/​test/​streamed-word-animation.browser.test.tsx Deletes streamed-word animation and identity checks.
packages/​solid-streamdown/​src/​streamdown.stories.tsx Removes two CSS-dependent story play functions.
packages/​mascot/​tests/​browser/​solid-wrapper.browser.test.tsx Removes consumer-style assertions.
packages/​mascot/​tests/​browser/​react-wrapper.browser.test.tsx Removes consumer-style assertions.
packages/​extensions/​page/​test/​page-tools.browser.test.tsx Removes inline-style tool test and fixture.
packages/​embed/​tests/​helpers/​host.ts Removes unused host HTML-attributes option.
packages/​embed/​tests/​e2e/​host-skin.it.test.ts Deletes host-skin integration suite.
packages/​embed/​tests/​e2e/​host-scheme.it.test.ts Deletes host color-scheme integration suite.
packages/​embed/​tests/​e2e/​fab-mascot.it.test.ts Removes launcher pose and pointer-tracking tests.
packages/​embed/​tests/​e2e/​fab-drag-snap.it.test.ts Removes resting-position drag test and settle helper.
packages/​brand/​vitest.config.ts Removes reduced-motion browser projects.
packages/​brand/​tsconfig.react.json Removes deleted React test entry.
packages/​brand/​tsconfig.json Removes deleted Solid test entry.
packages/​brand/​tests/​browser/​solid-lockup.browser.test.tsx Removes hover antenna-keyframe test.
packages/​brand/​tests/​browser/​solid-lockup-reduced-motion.browser.test.tsx Deletes Solid reduced-motion suite.
packages/​brand/​tests/​browser/​react-lockup.browser.test.tsx Removes hover antenna-keyframe test.
packages/​brand/​tests/​browser/​react-lockup-reduced-motion.browser.test.tsx Deletes React reduced-motion suite.
packages/​brand/​tests/​browser/​lockup-dom.ts Removes animation-keyframe inspection helper.
apps/​site/​test/​robot-fab.it.test.ts Removes sizing, hover-pose, and toggle tests.
.changeset/​delete-css-tests.md Records the test cleanup for release.

Review effort: Balanced

@@ -50,47 +31,6 @@ test.describe('the landing robot fab rides the mascot compound api', () => {
await page.close()
}, 60_000)

@@ -103,28 +77,3 @@ test('a launcher dropped past the viewport edge settles inward without ever leav
expect(outsideViewport(frames, viewport)).toEqual([])
expect(largestRetreat(frames)).toBeLessThanOrEqual(1)
})
const el = document.querySelector('#styled')
expect(el instanceof HTMLElement ? el.style.getPropertyValue('color') : '').toBe('rgb(1, 2, 3)')
})
})
@omridevk
omridevk merged commit ad66158 into main Oct 30, 2026
28 checks passed
@omridevk
omridevk deleted the delete-css-tests branch October 30, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants