Skip to content

ci: pin ruff in code quality workflow to the locked version - #246

Closed
garfield-oo7 wants to merge 1 commit into
coder:mainfrom
garfield-oo7:ci/pin-ruff
Closed

garfield-oo7 wants to merge 1 commit into
coder:mainfrom
garfield-oo7:ci/pin-ruff

Conversation

@garfield-oo7

Copy link
Copy Markdown

What

Pin astral-sh/ruff-action to Ruff 0.14.10 in both Ruff steps of .github/workflows/code_quality.yml, instead of version: latest.

Why

With latest, each new Ruff release turns on rules the code base doesn't follow yet. Ruff 0.17.4 reports 21 errors, all in existing files (for example cli/serve.py RUF028, manager.py UP041/PYI034, platforms/base.py ASYNC230, tests/lua/conftest.py UP035/B006). So the Ruff job fails on every pull request no matter what it changes. Recent runs on Dependabot and contributor PRs since September all fail the same way, and because the type-check/Markdown job needs: ruff, it gets skipped.

0.14.10 is the version in uv.lock (dev group ruff>=0.14.10), so CI now checks with the same Ruff as make lint / make format. Upgrading Ruff later is a deliberate bump of uv.lock plus this pin, together with any fixes the new rules need.

StyLua is unchanged.

How tested

  • make quality with Ruff 0.14.10 on main: ruff check passes and ruff format leaves all files unchanged.
  • This PR's own CI run uses the pinned version.

ruff-action used version: latest, so every new Ruff release turns on
rules the code base does not follow yet. Ruff 0.17.4 reports 21 errors
in files untouched by the PRs, so the Ruff job has been failing on every
pull request. Pin both steps to 0.14.10, the version in uv.lock and the
dev group (ruff>=0.14.10), so CI checks with the same Ruff as make lint.
@garfield-oo7

Copy link
Copy Markdown
Author

Closing, not needed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant