Repository navigation
ci: pin ruff in code quality workflow to the locked version - #246
Closed
garfield-oo7 wants to merge 1 commit into
Closed
garfield-oo7 wants to merge 1 commit into
garfield-oo7 wants to merge 1 commit into
Conversation
ruff-action used version: latest, so every new Ruff release turns on rules the code base does not follow yet. Ruff 0.17.4 reports 21 errors in files untouched by the PRs, so the Ruff job has been failing on every pull request. Pin both steps to 0.14.10, the version in uv.lock and the dev group (ruff>=0.14.10), so CI checks with the same Ruff as make lint.
Author
|
Closing, not needed for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
astral-sh/ruff-actionto Ruff0.14.10in both Ruff steps of.github/workflows/code_quality.yml, instead ofversion: latest.Why
With
latest, each new Ruff release turns on rules the code base doesn't follow yet. Ruff 0.17.4 reports 21 errors, all in existing files (for examplecli/serve.pyRUF028,manager.pyUP041/PYI034,platforms/base.pyASYNC230,tests/lua/conftest.pyUP035/B006). So the Ruff job fails on every pull request no matter what it changes. Recent runs on Dependabot and contributor PRs since September all fail the same way, and because the type-check/Markdown jobneeds: ruff, it gets skipped.0.14.10is the version inuv.lock(dev groupruff>=0.14.10), so CI now checks with the same Ruff asmake lint/make format. Upgrading Ruff later is a deliberate bump ofuv.lockplus this pin, together with any fixes the new rules need.StyLua is unchanged.
How tested
make qualitywith Ruff 0.14.10 onmain:ruff checkpasses andruff formatleaves all files unchanged.