Skip to content

fix(linux): support newer Lovely injector DLL naming - #242

Open
Clerval42 wants to merge 1 commit into
coder:mainfrom
Clerval42:fix/lovely-winmm-support
Open

Clerval42 wants to merge 1 commit into
coder:mainfrom
Clerval42:fix/lovely-winmm-support

Conversation

@Clerval42

Copy link
Copy Markdown

Problem

BalatroBot's Linux launcher fails to find newer Lovely Injector installations that provide winmm.dll.

Root cause

The launcher only searched for version.dll and always set WINEDLLOVERRIDES=version=n,b.

Solution

Detect winmm.dll first, fall back to version.dll, and set the Wine override for the selected DLL. Validate an explicitly configured Lovely path and report both supported names when auto-detection fails.

Backward compatibility

Existing version.dll installations retain WINEDLLOVERRIDES=version=n,b. An explicit lovely_path takes precedence over auto-detection.

Tests performed

Mock-based launcher tests cover both DLL names, selection when both exist, explicit paths, overrides, and missing files. 37 tests passed with 8 platform-specific skips. Ruff lint and format checks and ty check passed.

The full non-integration suite was not completed because an unrelated manager test stalled during a broader run.

Manual Linux verification

Before this PR preparation, uv run balatrobot serve started Balatro through Steam and Proton. The JSON-RPC server passed its health check on port 12346, the game opened, and the API responded to requests.

Limitations

The automated tests do not launch Steam, Proton, or Balatro. An explicit Lovely DLL path outside the Balatro directory is validated and determines the override name, but the launcher does not make that directory available to Wine. The DLL should be discoverable by Wine, normally beside Balatro.exe.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant