Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BalatroBot's Linux launcher fails to find newer Lovely Injector installations that provide
winmm.dll.Root cause
The launcher only searched for
version.dlland always setWINEDLLOVERRIDES=version=n,b.Solution
Detect
winmm.dllfirst, fall back toversion.dll, and set the Wine override for the selected DLL. Validate an explicitly configured Lovely path and report both supported names when auto-detection fails.Backward compatibility
Existing
version.dllinstallations retainWINEDLLOVERRIDES=version=n,b. An explicitlovely_pathtakes precedence over auto-detection.Tests performed
Mock-based launcher tests cover both DLL names, selection when both exist, explicit paths, overrides, and missing files. 37 tests passed with 8 platform-specific skips. Ruff lint and format checks and
ty checkpassed.The full non-integration suite was not completed because an unrelated manager test stalled during a broader run.
Manual Linux verification
Before this PR preparation,
uv run balatrobot servestarted Balatro through Steam and Proton. The JSON-RPC server passed its health check on port 12346, the game opened, and the API responded to requests.Limitations
The automated tests do not launch Steam, Proton, or Balatro. An explicit Lovely DLL path outside the Balatro directory is validated and determines the override name, but the launcher does not make that directory available to Wine. The DLL should be discoverable by Wine, normally beside
Balatro.exe.