Fail builds early when the configured main class is missing by shai-almog · Pull Request #6017 · codenameone/CodenameOne

shai-almog · 2026-10-14T00:57:10Z

When an app's main class is renamed or moved without updating its settings, builds can upload successfully and then fail in generated platform code. The shared Maven/Gradle build engine now validates the configured main class before invoking the build client or reusing a cached Android APK.

The error names the missing or stale class and directs the developer to mvn cn1:settings or to edit codename1.mainName and codename1.packageName in codenameone_settings.properties. It suggests a replacement only when exactly one live lifecycle class is identified. Staging-only builds also validate the main class.

Android cache keys include the selected main class, so switching between two existing entry points rebuilds the APK. Only an APK returned by the current build receives a new cache key.
Known project outputs are checked against their source roots to catch orphaned bytecode left by incremental compilation. Maven reactor directories and JARs use their producing module's source roots; binary dependencies do not require local source.

Validation: 179 focused tests passed under Java 8 across the build engine and Maven plugin. Coverage includes incremental renames/package moves, switching entry points through settings and command-line overrides, custom/generated source roots, binary dependencies, common-module directories/JARs, and existing source-scanning/provisioning/class-closure checks.

Gradle build tasks resolve the complete source set lazily, including Kotlin and added/generated roots. All 22 Gradle-plugin unit tests passed under Java 8, along with a real Gradle staging regression covering Java/Kotlin source roots, configuration-cache reuse, and rejection of orphaned bytecode. Targeted SpotBugs analysis reported no findings.

Fixes #6015.

shai-almog · 2026-10-14T00:57:42Z

@codex review

chatgpt-codex-connector · 2026-10-14T00:57:53Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-14T04:17:37.596828Z	`985151d`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 077f9e3768

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

shai-almog · 2026-10-14T01:22:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8d80d43b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

shai-almog · 2026-10-14T01:31:39Z

Compared 170 screenshots: 170 matched.

Native Android coverage

📊 Line coverage: 16.01% (26002/162390 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 14.37% (122147/850229), branch 9.91% (8466/85441), complexity 7.81% (6525/83503), method 11.59% (4648/40094), class 19.78% (960/4853)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6367 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.ClassReader – 0.00% (0/1524 lines covered)
  - org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.MethodWriter – 0.00% (0/922 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/736 lines covered)
  - com.google.common.cache.com.google.common.cache.LocalCache$Segment – 0.00% (0/726 lines covered)
  - okio.okio.Buffer – 0.00% (0/687 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/625 lines covered)
  - com.codename1.androidcompat.rt.com.codename1.androidcompat.rt.TextXmlPullParser – 0.00% (0/623 lines covered)
  - com.codename1.androidcompat.androidx.constraintlayout.core.widgets.com.codename1.androidcompat.androidx.constraintlayout.core.widgets.Flow – 0.00% (0/576 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 16.01% (26002/162390 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 14.37% (122147/850229), branch 9.91% (8466/85441), complexity 7.81% (6525/83503), method 11.59% (4648/40094), class 19.78% (960/4853)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6367 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.ClassReader – 0.00% (0/1524 lines covered)
  - org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.MethodWriter – 0.00% (0/922 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/736 lines covered)
  - com.google.common.cache.com.google.common.cache.LocalCache$Segment – 0.00% (0/726 lines covered)
  - okio.okio.Buffer – 0.00% (0/687 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/625 lines covered)
  - com.codename1.androidcompat.rt.com.codename1.androidcompat.rt.TextXmlPullParser – 0.00% (0/623 lines covered)
  - com.codename1.androidcompat.androidx.constraintlayout.core.widgets.com.codename1.androidcompat.androidx.constraintlayout.core.widgets.Flow – 0.00% (0/576 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
SIMD kernel backend	scalar fallback (no native SIMD)
SIMD int-add (64K x300)	java 113ms / native 163ms = 0.6x speedup
SIMD float-mul (64K x300)	java 100ms / native 57ms = 1.7x speedup
SIMD kernel correctness	PASS (native result == scalar reference)
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 SIMD byte path	gated to scalar (CPU autovectorizes scalar; explicit SIMD not beneficial here)
Base64 CN1 encode	88.000 ms
Base64 CN1 decode	73.000 ms
Base64 native encode	558.000 ms
Base64 encode ratio (CN1/native)	0.158x (84.2% faster)
Base64 native decode	350.000 ms
Base64 decode ratio (CN1/native)	0.209x (79.1% faster)
Image encode benchmark status	skipped (SIMD unsupported)

shai-almog · 2026-10-14T01:37:55Z

Compared 206 screenshots: 206 matched.
✅ JavaScript-port screenshot tests passed.

shai-almog · 2026-10-14T01:45:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3122862965

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-10-14T02:30:45Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 12326 total, 0 failed, 154 skipped
📊 Line coverage: 63.81% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.zip.ZipArchiveOutputStream – 0.00%
  - com.codename1.gaming.level.GameSceneView – 0.00%
  - com.codename1.crash.CrashProtection – 0.00%
  - com.codename1.payment.CommerceManager – 0.00%
  - com.codename1.wearable.WearableMessage – 0.00%
  - com.codename1.ui.plaf.GlassLensBlend – 0.00%
  - com.codename1.vr.VRView – 0.00%
  - com.codename1.appreview.RatingDialog – 0.00%
  - com.codename1.db.ManagedKeys – 0.00%
  - com.codename1.calendar.DefaultCalendarHttpTransport – 0.00%

Static Analysis

SpotBugs [Report archive]
- ✅ ByteCodeTranslator: 0 findings (no issues)
- ✅ android: 0 findings (no issues)
- ✅ android-compat: 0 findings (no issues)
- ✅ android-res-compiler: 0 findings (no issues)
- ✅ backend: 0 findings (no issues)
- ✅ backend-test: 0 findings (no issues)
- ✅ build-engine: 0 findings (no issues)
- ✅ build-hint-catalog: 0 findings (no issues)
- ✅ build-hint-tools: 0 findings (no issues)
- ✅ codenameone-gradle-plugin: 0 findings (no issues)
- ✅ codenameone-maven-plugin: 0 findings (no issues)
- ✅ core-unittests: 0 findings (no issues)
- ✅ ios: 0 findings (no issues)
- ✅ javac: 0 findings (no issues)
- ✅ project-model: 0 findings (no issues)
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-10-14T04:13:35Z

@codex review

chatgpt-codex-connector · 2026-10-14T04:17:36Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 985151d044

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Fail builds early when the configured main class is missing

077f9e3

chatgpt-codex-connector Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread maven/build-engine/src/main/java/com/codename1/maven/AppBuilder.java Outdated

Validate the main class before reusing cached Android builds

e8d80d4

chatgpt-codex-connector Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread maven/build-engine/src/main/java/com/codename1/maven/AppBuilder.java

Comment thread maven/build-engine/src/main/java/com/codename1/maven/MainClassPreflight.java

Track Android entry points and reject orphaned main classes

3122862

chatgpt-codex-connector Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread maven/build-engine/src/main/java/com/codename1/maven/AppBuilder.java

Pass all Gradle source roots to the main class preflight

985151d

Check configuration cache reuse with consecutive identical Gradle inputs

3c0ae9a

Conversation

shai-almog commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shai-almog commented Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

shai-almog commented Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

shai-almog commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

shai-almog commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shai-almog commented Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented Oct 14, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 14, 2026 •

edited

Loading

shai-almog commented Oct 14, 2026 •

edited

Loading

shai-almog commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading