Repository navigation
Conversation
IncomingRequest::isSecure() compared the trusted proxy's X-Forwarded-Proto value with a case-sensitive === 'https', so a proxy sending 'HTTPS' was not recognized as secure. The comparison is now case-insensitive and ignores ambiguous multi-valued headers, which cannot be trusted.
carson-codeigniter4
Bot
added
bug
|
Hi there, @gr8man! 👋 It looks like this pull request does not follow our template:
Please update the description to follow the template. The |
carson-codeigniter4
Bot
removed
the
needs template
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed
IncomingRequest::isSecure()not recognizing a trusted proxy'sX-Forwarded-Proto: HTTPSvalue because the comparison was case-sensitive. Ambiguous multi-valued headers are now ignored, as they cannot be trusted.Checklist: