Skip to content

fix: handle invalid values and empty tag names in XMLFormatter - #10626

Open
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/xmlformatter-invalid-values
Open

gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/xmlformatter-invalid-values

Conversation

@gr8man

@gr8man gr8man commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Description
Fixes a bug in XMLFormatter where an array key that becomes empty after sanitization threw a ValueError, and a value of a non-stringable object caused a fatal Error. Such keys now fall back to the tag name item, and non-stringable values throw a FormatException.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added bug Verified issues on the current code behavior or pull requests that will fix them needs template Opened issues not following the bug form template labels Oct 12, 2026
@carson-codeigniter4

Copy link
Copy Markdown

Hi there, @gr8man! 👋

It looks like this pull request does not follow our template:

Please update the description to follow the template. The needs template label will be removed automatically once it does.

@carson-codeigniter4 carson-codeigniter4 Bot removed the needs template Opened issues not following the bug form template label Oct 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant