Skip to content

style: replace have_no_selector with have_no_css in stats specs #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroderick merged 1 commit into from
Oct 30, 2026
Merged

style: replace have_no_selector with have_no_css in stats specs #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/components/admin/stats/table_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

render_inline(described_class.new(months: [Date.new(2026, 6, 1)], rows: [workshops_row], caption: 'Workshops'))

expect(attendance_table).to have_no_selector('td[colspan]')
expect(attendance_table).to have_no_css('td[colspan]')
expect(page).to have_css('caption', text: 'Workshops')
end

Expand Down
10 changes: 5 additions & 5 deletions spec/features/admin/stats_page_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
expect(page).to have_css('caption', text: 'New sign-ups')
expect(page).to have_css('caption', text: 'Workshops')
expect(page).to have_css('th', text: 'August 2026')
expect(page).to have_no_selector('th', text: 'September 2026')
expect(page).to have_no_selector('th', text: 'May 2026')
expect(page).to have_no_css('th', text: 'September 2026')
expect(page).to have_no_css('th', text: 'May 2026')
expect(page).to have_css('.btn-outline-primary.active', text: '3 months')
expect(page).to have_link('Download CSV')
end
Expand All @@ -38,7 +38,7 @@
expect(page).to have_css('th', text: 'June 2026')
expect(page).to have_css('th', text: 'July 2026')
expect(page).to have_css('th', text: 'August 2026')
expect(page).to have_no_selector('th', text: 'May 2026')
expect(page).to have_no_css('th', text: 'May 2026')
end
end

Expand All @@ -50,8 +50,8 @@
visit admin_stats_path(stats: { start_month: '2026-06', end_month: '2026-06' })

expect(page).to have_css('th', text: 'June 2026')
expect(page).to have_no_selector('th', text: 'May 2026')
expect(page).to have_no_selector('th', text: 'July 2026')
expect(page).to have_no_css('th', text: 'May 2026')
expect(page).to have_no_css('th', text: 'July 2026')

expect(find('tr', text: 'New coaches')).to have_text('1')
expect(find('tr', text: 'New students')).to have_text('0')
Expand Down
Loading