Repository navigation
tunnet: offer USO6 so a guest kernel enables UDP segmentation offload - #539
Merged
Merged
Conversation
The guest enables USO only as the USO4 and USO6 pair, and the host offered USO4 alone, so every guest frame carried one datagram. With USO6 offered, UDP_SEGMENT senders in the guest run at 2438 vs 972 Mbit/s to a server netns and 1897 vs 878 Mbit/s to the host (8 ABBA runs each, p=0.0008); plain UDP is unchanged. The host still drops IPv6 frames as it drops any non-IPv4 packet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guest kernel enables USO only when both USO4 and USO6 are offered. The host's hello offered USO4 alone, so the guest's
tun0kepttx-udp-segmentationoff. Every frame the guest sent therefore carried a single datagram, and the host's UDP GSO path never ran.Change
OffloadUSO6 = 0x40is added tosegmentable.docs/advanced-network.md: the hello table and the offload paragraph now list USO6.TestRouterAnnouncesRewritesAndPassesOnlyRepliesasserts that the host hello carries both TSO4 and the USO pair. The test fails against the oldsegmentable.Evidence (hardware, base e38c762; 8 runs per arm in ABBABAAB order)
Host to guest is unaffected: the host merges only TCP toward the guest.
Gates
make go-lint: 10×0 issues.asl -forwarder=false ./...: clean on both GOOS.go test -race ./tunnet/: ok.