Skip to content

Fix ProxyService crash on dataset updates for tasks without a contest - #1727

Open
pxsit wants to merge 1 commit into
cms-dev:mainfrom
pxsit:bugfixx
Open

pxsit wants to merge 1 commit into
cms-dev:mainfrom
pxsit:bugfixx

Conversation

@pxsit

@pxsit pxsit commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Dataset updates for tasks without a contest crashed while logging why the update was ignored.
Fixed by using the nullable contest_id

Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.74%. Comparing base (1914a5a) to head (35291bf).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   56.72%   56.74%   +0.02%     
==========================================
  Files         344      344              
  Lines       28312    28312              
==========================================
+ Hits        16060    16067       +7     
+ Misses      12252    12245       -7     
Flag Coverage Δ
functionaltests 0.00% <ø> (ø)
unittests 56.74% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants