Repository navigation
Conversation
pan-kot
requested review from
amanabiy and
srungta08
and removed request for
a team and
amanabiy
November 12, 2026 07:58
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the zoom-control focus refactor.
No open issues 🎉
What changed in this PR
Refactors focus handling for the internal chart zoom controls, moving it from React effects into the zoom state machine and chart helper.
Changes:
- Adds explicit focus targets for entering, cancelling, and committing zoom selections.
- Registers button references with the chart API and keeps Reset mounted so it can receive focus before state renders.
- Updates control spacing, state-machine tests, and test helpers.
| File | Description |
|---|---|
src/core/styles.scss |
Adds spacing between zoom controls. |
src/core/components/core-zoom-controls.tsx |
Registers focus references and keeps Reset mounted in a hidden wrapper. |
src/core/chart-zoom/zoom-state-machine.ts |
Replaces operation notifications with explicit focus effects. |
src/core/chart-zoom/__tests__/zoom-state-machine.test.ts |
Updates expected effects and adds blur-cancellation coverage. |
src/core/chart-api/index.tsx |
Exposes zoom-button reference setters. |
src/core/chart-api/chart-extra-zoom.ts |
Centralizes focus handling for zoom transitions and reset. |
src/core/__tests__/common.tsx |
Excludes hidden Reset buttons from test lookups. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See: #278 (comment)
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.