Skip to content

fix(puppeteer): keep Workers only Response type globals out of exported types - #260

Merged
Refaerds merged 2 commits into
cloudflare:mainfrom
mkuritsu:rcorreia/fix-node-types-mismatch
Nov 16, 2026
Merged

Refaerds merged 2 commits into
cloudflare:mainfrom
mkuritsu:rcorreia/fix-node-types-mismatch

Conversation

@mkuritsu

Copy link
Copy Markdown
Member

Small PR to move the Response and WebSocket interface declarations to workers types so they are not exported.

This was causing type conflicts when using this package along side node type definitions, having conflicts in the Response type

@clanky-the-clanker

Copy link
Copy Markdown

This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting clanky review (or clanker review or @clanky-the-clanker review), optionally followed by instructions (e.g. clanky review focus on the retry logic).

@Refaerds
Refaerds merged commit 6bcf835 into cloudflare:main Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants