Repository navigation
Stop reporting failed scale set deletes as success - #928
Merged
gabriel-samfira merged 1 commit intoOct 23, 2026
Merged
gabriel-samfira merged 1 commit into
gabriel-samfira merged 1 commit into
Conversation
LucaCappelletti94
force-pushed
the
upstream/garm-scaleset-delete-error-check
branch
from
October 23, 2026 19:05
096df86 to
fcc4bc6
Compare
Member
|
Ohh wow! I really need to sleep more. Great catch! |
Contributor
Author
We all do, we all do. I just happened to find this because I migrated setup between orgs. |
gabriel-samfira
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteScaleSetByIDinverted itsErrNotFoundcheck. A GitHub failure returned success and kept the record, which then blocks deleting the entity, while a 404 on the scale set returned an error. The actions service also answers 404 on/actions/runner-registrationfor a renamed or transferred repository, which would then read as the scale set being gone. Map that to a conflict naming the entity, as #918 does for the registration token, soErrNotFoundfrom the scale set client only means the scale set or runner itself.