Repository navigation
#310 - Configuration: deprecate an unknown task error_strategy, boolean public, describe the nodes - #314
Merged
Conversation
…an public, describe the nodes - A task error_strategy other than skip or stop is deprecated: notice when the container is compiled (CleverAgeProcessExtension), it will be rejected in v6.0. It was accepted, and the process failed with "Unknown error strategy" when the task failed. Environment variables are not checked. - The process "public" key is a booleanNode: a non-boolean value is rejected when the container is compiled instead of a TypeError when the ProcessConfiguration is built. - ->info() / ->example() on the nodes of the process, task and generic transformer configurations (config:dump-reference clever_age_process). - Tests, documentation (process and task definition) and CHANGELOG updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #310.
Unknown task
error_strategydeprecatedCleverAgeProcessExtension::checkErrorStrategies(): a taskerror_strategyother thanskiporstoptriggers a deprecation when the container is compiled, giving the process and the task:The error strategy "skp" of the task "typo" of the process "test.process" is unknown, use "skip" or "stop" (or remove it to use the "default_error_strategy"). Unknown error strategies are deprecated, they will be rejected in v6.0.Unknown error strategy 'skp'only when the task failed; a task that never fails works with it, hence a deprecation instead of a rejection (v6.0: remove the deprecated code #292 for v6.0).TypeErrorinTaskConfiguration).publicis a boolean nodeTypeErrorin theProcessConfigurationconstructor: it is now rejected when the container is compiled (Invalid type for path "clever_age_process.configurations.<code>.public". Expected "bool"...). No BC break, the wrong values already crashed.Nodes described
->info()(and->example()onoutputs,error_outputs,contextual_options,transformers) ondefault_error_strategy, the process nodes (entry_point,end_point,description,help,public,options), the task nodes (description,help,options,error_strategy,log_level,outputs,error_outputs) and the generic transformer nodes: shown byconfig:dump-reference clever_age_process.Documentation: process and task definition reference pages. CHANGELOG.
Tests (
ConfigurationTest): the deprecation (unset,skip,stopand environment variable without notice, a typo with one notice),publicrejected when not a boolean.Checked in the container (979 tests): highest dependencies (PHP 8.5, Symfony 8.1), lowest dependencies (PHP 8.2, Symfony 6.4.0), Symfony 6.4.48 on PHP 8.2 and 8.5, Symfony 7.4: no deprecation, no risky test (with pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.
Requirements
Breaking changes
None. New deprecation (5.4): a task
error_strategyother thanskiporstop, rejected in v6.0 (#292). A non-booleanpublicis rejected earlier, it already failed.🤖 Generated with Claude Code