Skip to content

🧪 Bump macOS Tests runners to macos-26 - #862

Open
julianz- wants to merge 1 commit into
cherrypy:mainfrom
julianz-:fix/macos-arm-tests-timeout
Open

julianz- wants to merge 1 commit into
cherrypy:mainfrom
julianz-:fix/macos-arm-tests-timeout

Conversation

@julianz-

@julianz- julianz- commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

What do these changes do?

Bumps the macOS CI runners in the Tests matrix from macos-15/macos-15-intel
to macos-26/macos-26-intel, and raises the matrix's timeout-minutes from
7 to 9. The 7-minute timeout had started cancelling jobs on the old images
even after every step had already succeeded (seen on #838 and #859, among
others).

Measured ~3.15.0-0 @ macos-26-intel (the slowest job in the matrix) across
three runs on the new images: 4m26s, 6m33s, and 6m05s. Applying
+30% margin to the worst of those (6m33s * 1.3 ≈ 8m31s) rounds up to 9
minutes.

Are there changes in behavior for the user?

No. CI-only.

Is it a substantial burden for the maintainers to support this?

No.

Related issue number

Discussed on #838.

Checklist

  • I wrote descriptive pull request text above
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences
  • I think the code is well written
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Project documentation (in docs/) and inline docstrings reflect the changes
  • My commits each have a descriptive title and a body explaining the why
    (see [good commit messages])
  • I have added a [change log entry]
  • I'm planning to [squash related commits] together before final merge
  • I have read the [contribution guide] and the

@julianz-
julianz- force-pushed the fix/macos-arm-tests-timeout branch from 1fc2600 to a3ef063 Compare October 22, 2026 23:19
@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided A mark meaning that a new change log entry is present within the patch. label Oct 22, 2026
@read-the-docs-community

read-the-docs-community Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 cheroot | 🛠️ Build #35349496 | 📁 Comparing 046c816 against latest (8402e55)

  🔍 Preview build  

2 files changed
± history/index.html
± pkg/cheroot.server/index.html

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.20%. Comparing base (8402e55) to head (046c816).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files          41       41           
  Lines        4791     4791           
  Branches      548      548           
=======================================
  Hits         3747     3747           
- Misses        904      905    +1     
+ Partials      140      139    -1     

@julianz-
julianz- force-pushed the fix/macos-arm-tests-timeout branch 3 times, most recently from 641a90d to 13b4dca Compare October 23, 2026 00:54
@julianz-
julianz- requested a review from webknjaz October 23, 2026 09:01
@julianz-
julianz- force-pushed the fix/macos-arm-tests-timeout branch 2 times, most recently from 2539253 to fdf8939 Compare October 23, 2026 09:07
macos-15 and macos-15-intel are GitHub's previous-generation macOS
runner images; macos-26 and macos-26-intel are current.

The matrix's 7-minute timeout-minutes was cancelling jobs on the old
images that had already passed every step. Measured the worst case
on the new images across three runs: ~3.15.0-0 @ macos-26-intel took
4m26s, 6m33s, and 6m05s. 9 minutes applies a 30% margin over the
slowest of those.
@julianz-
julianz- force-pushed the fix/macos-arm-tests-timeout branch from fdf8939 to 046c816 Compare October 23, 2026 09:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided A mark meaning that a new change log entry is present within the patch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant