Repository navigation
Conversation
julianz-
force-pushed
the
fix/macos-arm-tests-timeout
branch
from
October 22, 2026 23:19
1fc2600 to
a3ef063
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 78.20% 78.20%
=======================================
Files 41 41
Lines 4791 4791
Branches 548 548
=======================================
Hits 3747 3747
- Misses 904 905 +1
+ Partials 140 139 -1 |
julianz-
force-pushed
the
fix/macos-arm-tests-timeout
branch
3 times, most recently
from
October 23, 2026 00:54
641a90d to
13b4dca
Compare
julianz-
force-pushed
the
fix/macos-arm-tests-timeout
branch
2 times, most recently
from
October 23, 2026 09:07
2539253 to
fdf8939
Compare
macos-15 and macos-15-intel are GitHub's previous-generation macOS runner images; macos-26 and macos-26-intel are current. The matrix's 7-minute timeout-minutes was cancelling jobs on the old images that had already passed every step. Measured the worst case on the new images across three runs: ~3.15.0-0 @ macos-26-intel took 4m26s, 6m33s, and 6m05s. 9 minutes applies a 30% margin over the slowest of those.
julianz-
force-pushed
the
fix/macos-arm-tests-timeout
branch
from
October 23, 2026 09:14
fdf8939 to
046c816
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What do these changes do?
Bumps the macOS CI runners in the
Testsmatrix frommacos-15/macos-15-intelto
macos-26/macos-26-intel, and raises the matrix'stimeout-minutesfrom7 to 9. The 7-minute timeout had started cancelling jobs on the old images
even after every step had already succeeded (seen on #838 and #859, among
others).
Measured
~3.15.0-0 @ macos-26-intel(the slowest job in the matrix) acrossthree runs on the new images: 4m26s, 6m33s, and 6m05s. Applying
+30% margin to the worst of those (6m33s * 1.3 ≈ 8m31s) rounds up to 9
minutes.
Are there changes in behavior for the user?
No. CI-only.
Is it a substantial burden for the maintainers to support this?
No.
Related issue number
Discussed on #838.
Checklist
and description in grammatically correct, complete sentences
docs/) and inline docstrings reflect the changes(see [good commit messages])