Skip to content

fix: update brace-expansion to patched version - #855

Open
sbouchet wants to merge 2 commits into
che-incubator:mainfrom
sbouchet:fix-brace-expansion-cves
Open

sbouchet wants to merge 2 commits into
che-incubator:mainfrom
sbouchet:fix-brace-expansion-cves

Conversation

@sbouchet

@sbouchet sbouchet commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR fixes CVE-2026-102278 and CVE-2026-102276
brace-expansion version is updated to 1.1.22

What issues does this PR fix?

https://redhat.atlassian.net/browse/CRW-13683
https://redhat.atlassian.net/browse/CRW-13650

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Summary by CodeRabbit

  • Chores
    • Updated an underlying package version range across several app components. No user-facing changes are included in this update.

…, CVE-2026-102278)

Raise the brace-expansion@1 override from ^1.1.18 to ^1.1.22 in the Che
extensions (che-api, che-port, che-remote, che-resource-monitor) and the
launcher. These dev-only chains (jest/eslint -> minimatch@3) still
resolved 1.1.18; upstream workspaces were already fixed by the 1.143.1
alignment (che-incubator#845).

Closes Dependabot alerts #1479-#1481, #1492-#1497, #1499-#1501,
#1574-#1576 (CRW-13683, CRW-13650).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Click here to review and test in web IDE: Contribute

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f975485 and 5fc1cf1.

Files ignored due to path filters: 5

  • code/extensions/che-api/package-lock.json is excluded by !**/package-lock.json
  • code/extensions/che-port/package-lock.json is excluded by !**/package-lock.json
  • code/extensions/che-remote/package-lock.json is excluded by !**/package-lock.json
  • code/extensions/che-resource-monitor/package-lock.json is excluded by !**/package-lock.json
  • launcher/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 5

  • code/extensions/che-api/package.json
  • code/extensions/che-port/package.json
  • code/extensions/che-remote/package.json
  • code/extensions/che-resource-monitor/package.json
  • launcher/package.json

No actionable comments were generated in the recent review.

Walkthrough

The brace-expansion@1 override range changes from ^1.1.18 to ^1.1.22 in the package manifests for four extensions and the launcher.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · previous review f9754

This updates a dependency override to a patched brace-expansion version in development-only dependency chains. No runtime behavior change or merge-blocking risk was found.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title "fix: update brace-expansion to patched version" matches the main change. The PR raises the brace-expansion@1 override from ^1.1.18 to ^1.1.22 in five package.json files to address the repor…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Rebase Rules For Upstream Changes Passed The check applies only when files under code/ change, excluding code/extensions/che-*/** and **/package-lock.json. The changed-file inventory (git diff --name-status on the review range) lists…
Full details: Title check

Explanation

The title "fix: update brace-expansion to patched version" matches the main change. The PR raises the brace-expansion@1 override from ^1.1.18 to ^1.1.22 in five package.json files to address the reported CVEs. The title is 46 characters, under the 72-character limit. It uses a conventional prefix and the imperative verb "update". The PR does not specify tests, but the title check does not require them.

Full details: Rebase Rules For Upstream Changes

Explanation

The check applies only when files under code/ change, excluding code/extensions/che-*/** and **/package-lock.json. The changed-file inventory (git diff --name-status on the review range) lists 10 files: - code/extensions/che-api, che-port, che-remote, and che-resource-monitor: package.json and package-lock.json each. All fall under the excluded code/extensions/che-*/** path or are lock files. - launcher/package.json and launcher/package-lock.json: outside code/. No changed file falls under code/ after the exclusions. The check is not triggered. The PR does not need .rebase/ rules, a .rebase/CHANGELOG.md entry, or rebase.sh routing for this change. The PR template checkboxes are not required by this check's criteria.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8120ad7 and f975485.

Files ignored due to path filters: 5

  • code/extensions/che-api/package-lock.json is excluded by !**/package-lock.json
  • code/extensions/che-port/package-lock.json is excluded by !**/package-lock.json
  • code/extensions/che-remote/package-lock.json is excluded by !**/package-lock.json
  • code/extensions/che-resource-monitor/package-lock.json is excluded by !**/package-lock.json
  • launcher/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 5

  • code/extensions/che-api/package.json
  • code/extensions/che-port/package.json
  • code/extensions/che-remote/package.json
  • code/extensions/che-resource-monitor/package.json
  • launcher/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

@RomanNikitenko RomanNikitenko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brace-expansion was bumped to 1.1.22 version within the current PR
I found che-github-authentication extension still uses 1.1.21 version:

As far as I understand 1.1.21 is a minimum fixed version, so it also should be OK.

@sbouchet

sbouchet commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator Author

Thanks — confirmed: per the advisories, 1.x fixes land at 1.1.19 / 1.1.20 / 1.1.21 for CVE-2026-102276 / CVE-2026-102278 / CVE-2026-102277, so 1.1.21 in che-github-authentication (and the upstream lockfiles) is already patched and has no open alerts. 1.1.22 here is just the latest release that ^1.1.22 resolved to; no change needed for now.

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants