Repository navigation
Added reactor tests to make check - #6447
Merged
Merged
Conversation
victormlg
changed the title
Contributor
Author
|
@cf-bottom jenkins, please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14899/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14899/ |
Added the reactor tests to jenkins, to be able to run them in jenkins. This means we can test cf-reactor on all the different platforms. Signed-off-by: Victor Moene <victor.moene@northern.tech>
Made the logs prettier and added a log file where the xtrace is printed Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.RunTestsInJenkins
branch
from
October 28, 2026 11:55
824257a to
5f352d3
Compare
Contributor
Author
|
Forgot to rebase: |
The guest environment cannot contain "-". On hosts containing "-", the promise fails. The host name is now canonofied. Signed-off-by: Victor Moene <victor.moene@northern.tech>
Contributor
Author
|
Fixed two bugs: |
victormlg
force-pushed
the
cf-reactor.RunTestsInJenkins
branch
from
October 28, 2026 15:19
59bcb95 to
5d02ad6
Compare
larsewi
marked this pull request as draft
October 28, 2026 15:31
Contributor
|
Converted to draft while you work on it |
The test promised the current user with policy "present" and expected the promise to be kept. For an existing user, "present" also means "not locked". When run as root, cf-reactor can read /etc/shadow, and if the account's password hash starts with '!' (as root's does on some systems), it is considered locked and gets unlocked. The promise was then repaired instead of kept, and the test modified the root account. As a normal user, /etc/shadow is unreadable, so the account was considered unlocked and the test passed. Instead, we modify the policy to always return "kept" Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.RunTestsInJenkins
branch
from
October 29, 2026 10:47
5d02ad6 to
045402d
Compare
Contributor
Author
|
|
larsewi
approved these changes
Oct 30, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Please investigate what happened to the windows acceptance tests. Is it related?
|
|
||
| t=$1 | ||
|
|
||
| # Explicitly use POSIX tools if needed (Solaris) |
Contributor
There was a problem hiding this comment.
We don't support Solaris anymore.
Comment on lines
+13
to
+16
| # Run command $@ until it succeeds, for at most WAIT_TIMEOUT seconds, polling | ||
| # every 0.1 second, or every second where sleep only takes whole seconds. | ||
| # Fails if it never succeeded. Runs in a subshell without tracing, so that | ||
| # set -x doesn't log every poll. |
Contributor
There was a problem hiding this comment.
Was this a problem on any of the supported platforms?
Comment on lines
+33
to
+34
| # Print the current time in seconds since the Epoch. date +%s is not POSIX; | ||
| # without it, srand() seeds with the time of day and returns the last seed. |
Contributor
|
Maybe @craigcomstock can have a look at this too? |
Contributor
|
Windows test failure is unrelated. I will merge, since it unblocks work. Feel free to review post merge @craigcomstock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.