Repository navigation
fix: encode ASM tag names in delete requests - #735
Open
Max Gorbuk (mkzung) wants to merge 2 commits into
Open
Max Gorbuk (mkzung) wants to merge 2 commits into
Max Gorbuk (mkzung) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deleting the ASM tag
team#1sendsteambecause Requests treats#1as a URL fragment.Changes
Encode tag names as one path segment across ASM asset types. Reject exact
.and..names before any request because URL normalization changes their route. Add regression tests for reserved characters and dot segments.Checklist
Linux/Windows CI and live API tag-name validation were not run. Python 3.9 emits a LibreSSL warning; HTTPS interoperability was not tested.