Repository navigation
Add support for headers within leading region wrappers in licence hea… - #47
Merged
Merged
Conversation
…der checks NO_JIRA
Contributor
Author
|
The checks for licenses should really check the file and not a header |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved issues remain with directive recognition and repairing invalid wrapped headers.
2 open issues
What changed in this PR
Adds support for validating licence headers inside leading #region wrappers, with regression tests.
Changes:
- Adds region-wrapper handling during validation.
- Adds wrapped-header test coverage.
- Requires directive-boundary checks and wrapper-aware repair logic.
| File | Summary |
|---|---|
test/test_licence_headers.py |
Adds tests for wrapped licence headers. |
main/licence_headers.py |
Implements region-aware validation; repair handling remains incomplete. |
Review effort: Lite
…rresponding tests NO_JIRA
aseidu-ccdc
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…der checks NO_JIRA