[mariayord]

Fixes: https://github.tools.sap/cap/cdsnode/issues/2899

[hyperspace-pr-bot]

Control Panel

Hi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
To interact with me, just use the following actions:

• 📝 Summarize PR
• 🔍 Review
• 🗑️ Delete all bot comments and reviews

[sjvans]

Suggested change

	<tr>
	<td>
	```json
	{
	"cds": {
	"requires": {
	"my-service": {
	"vcap": { "tag": "my-tag" }
	}
	}
	}
	}
	```
	</td>
	<td>
	```json
	{
	"user-provided": [
	{ "name": "other-upsi", "tags": ["other-tag"] },
	{ "name": "my-upsi", "tags": ["my-tag"] }
	]
	}
	```
	</td>
	</tr>

[sjvans]

Suggested change

	<tr>
	<td>
	```json
	{
	"cds": {
	"requires": {
	"my-service": {}
	}
	}
	}
	```
	</td>
	<td>
	```json
	{
	"user-provided": [{
	"name": "my-service",
	"tags": []
	}]
	}
	```
	</td>
	</tr>
	<tr>
	<td>
	```json
	{
	"cds": {
	"requires": {
	"my-service": {}
	}
	}
	}
	```
	</td>
	<td>
	```json
	{
	"user-provided": [{
	"name": "my-upsi",
	"tags": ["cds:my-service"]
	}]
	}
	```
	</td>
	</tr>
	<tr>
	<td>
	```json
	{
	"cds": {
	"requires": {
	"my-service": {
	"kind": "my-kind"
	}
	}
	}
	}
	```
	</td>
	<td>
	```json
	{
	"user-provided": [{
	"name": "my-upsi",
	"tags": ["my-kind"]
	}]
	}
	```
	</td>
	</tr>

[sjvans]

i think we should only list this option:

they can freely choose the name of their user provided service instance, so this option is both easy and 100% reliable

[sjvans]

Suggested change

	{
	"user-provided": [{
	"name": "my-upsi",
	"tags": []
	}]
	}
	{
	"VCAP_SERVICES": {
	"user-provided": [{
	"name": "my-upsi"
	}]
	}
	}

[mariayord]

@sjvans If you want to point only one option, than it make sense to delete also the clarification:
Because all UPSIs share the same key, matching by kind label or type does not apply — only name and tag matching works. Use an explicit vcap config to override auto-matching

Here the point is that not all rules(1-7) listed above are valid for user-provided case.

[sjvans]

right, it's only rule 7: "The service's vcap.name is matched against the name property". i don't like the tag option because they are not unique → error prone. maybe we say we recommend matching by name above the example?

[sjvans]

but i'd defer to @renejeglinsky and @smahati :)