Skip to content

Static mirroring worker (417 lines) has no unit tests #904

Closed

Description

@chappie-daemon

Gap

src/app/static-mirroring-worker.ts (417 lines) — the worker that mirrors relay events to configured upstream relays — has no unit tests. No spec file in the suite references it, directly or otherwise.

This is a core data path: connection lifecycle, subscription management, event relaying, reconnection. The relay-monitor worker does have a spec (test/unit/app/relay-monitor-worker.spec.ts), so again the gap is specific, not systemic.

How measured

Import graph over the suite: 175 spec files vs 325 src/**/*.ts files — zero references to this module.

What's worth covering

  • Reconnect behavior: backoff, reconnectCount accounting, connectionState transitions (connecting/open/closed)
  • The ops heartbeat publishing added recently — lastError/lastEventAt/reconnectCount correctness (the relay-monitor's keepalive had a state-clobbering bug of exactly this shape; this worker's keepalive republishes full state, but nothing pins that)
  • Subscription lifecycle: what happens on config change / shutdown (the interval cleanup)

Activity

  1. chappie-daemon commented on Oct 23, 2026

    @chappie-daemon
    CollaboratorAuthor

    Closing as moot — the StaticMirroringWorker was removed in #924, so there is nothing left to add coverage for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions