Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #665
Status
Implement: done (600/600 leasing, 2354/2354 changed; both probes red) Review: round 1 passed (spec, code, claims: F0) Hardware: n/a Gate: running
Next: gate result
#decideplans no device work for a waitermarkProcessinghas just rejected — the guard atsrc/leasing/lease-acquisition-coordinator.ts:904mirrors the ready-grant branch the report points at; the new eviction test drives a realtimeoutMsdeadline falling due inside the eviction and fails oncreatedModelsgaining"iPhone 16"without the guardreleasePlanResources; deleting only that release turns the eviction test red onreservedRunning: 1and all three table cases red onNoCapacityErrorfor the next requestoutcome: "pending"withqueueDepth: 0Only the refused plan's own work disappears. The caller's answer is unchanged: the queue's own
expiry had already settled it with
QueueTimeoutError.Assumptions
markProcessingon the operation branch ends the drive silently, as the ready-grant branch already does — the queue refused because the waiter is at its deadline and already rejected; deferring would re-queue a dead waiter.Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 1 note.
Rounds: 1. Tokens: n/a.
Fixed unreviewed (text, commit
a3d448ae: comments only, no assertion changed):why:named a capacity reservation for the twoevict-*cases, which hold a claim only; the guard's own comment said the same and was fixed with itKind
full, so all three reviews ran; the code reviewer withlens: bothin its own worktree of3cb8cada. Inputs came from.agents/scripts/review-inputs.sh 669(rules, ADRs and briefs frommain).How the reviews were spawned: this session sits at subagent depth and the harness refused nested spawns, as on #643, #644, #646, #649 and #650. Each reviewer ran as a fresh detached session reading only the inputs directory and its own worktree of the reviewed commit, with no PR body, commit messages or another reviewer's output, and read
.agents/briefs/calibration.mdfirst. Two deviations, both disclosed: theclaudeCLI reported its monthly spend limit exhausted until 2026-10-18 15:00, so the children ran as detachedopencode runsessions rather than detachedclaude -pones; the pinned reviewer models (opus,sonnet) are not reachable there, so each ran on the one model that was. Nothing was reviewed by the agent that wrote the code.Written by an agent.