Repository navigation
Conversation
… leases and devices as zero
… starting 1 failing -> 0 failing
…e shows while a worker starts (#406)
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
The overview read a starting worker's absent
leases/devicesas zero, so thefleet's tiles, chart, capacity bars and worker rows named counts that treated
the unknown as none. Absent now stays unknown.
Done when
—, not a count —ui/src/model/overview.ts:154-166; thecarried test asserts
Utilisation —andLeases —.overview.ts:193-194; same test:minutes[],chartSummary"". The panel says "Not reported.".overview.ts:114-127; same test: noleasesproperty, that label.overview.ts:84-88, and the screen prints adash and draws no share bar for it (a bar only shades a printed figure).
keeps its own figures — same test, second case.
waits out the
startingwindow (e2e/console/fixtures.ts:209).Deleting the
isUnreadguard reddens the test on its—assertion; deletingthe row's label or the bar guard reddens each named assertion.
Status
Implement: done (2/2 green) Review: round 1 (2 src fixed), round 2 F0, fix-check F0 Hardware: n/a Gate: merged (cb43a46)
Next: none
Assumptions
docs/internal/DESIGN.md), and an empty one reads as "nothing leased", the claim this bug is about.Review
Spec review: 0 blocking, 2 fixed, 0 notes. Code review: 0 blocking, 1 fixed, 1 note. Claims review: 0 blocking, 0 fixed, 1 note.
Rounds: 2. Tokens: n/a.
Kind
full, so all three reviews ran round 1, the code reviewer withlens: both. Three round-1 notes claimed wrong state or a rule breach, so each was verified: two were confirmed and fixed (the unknown tiles named a unit no test could pin, so the unit is omitted while unknown; an unread platform still drew an empty share bar), and one was adocs/CONSOLE.mdline saying the dash appears "while it is starting" when a worker that disconnects while starting keeps its leases absent too (src/gateway/worker-registry.ts:422-441). Twosrcfixes took round 2 (code + claims), both F0; the comment-lint fix to the test's own comments took the fix check, also F0.Rejected:
lint:commentsis what rules on it; the lint then rejected six comments and that fix went through the fix check.How the reviews were spawned: this session sits at subagent depth and the harness refused nested spawns, as on #643 and #644. Each reviewer ran as a fresh detached
claude -psession — the body of.claude/agents/<reviewer>.mdas its system prompt, its model from that file's frontmatter — reading only itsreview-inputs.shdirectory and its own worktree of the reviewed commit, blind to this body, the commit messages and each other. Nothing was reviewed by the agent that wrote the code.Written by an agent.