Skip to content

fix(console): show fleet lease and device figures as unknown while a worker is starting - #651

Merged
V3RON merged 5 commits into
mainfrom
bug/406
Oct 17, 2026
Merged

V3RON merged 5 commits into
mainfrom
bug/406

Conversation

@V3RON

@V3RON V3RON commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #406

The overview read a starting worker's absent leases/devices as zero, so the
fleet's tiles, chart, capacity bars and worker rows named counts that treated
the unknown as none. Absent now stays unknown.

Done when

  • Tiles show —, not a count — ui/src/model/overview.ts:154-166; the
    carried test asserts Utilisation — and Leases —.
  • The chart returns no minutes — overview.ts:193-194; same test:
    minutes [], chartSummary "". The panel says "Not reported.".
  • A worker row omits its lease count and says "Not reported" —
    overview.ts:114-127; same test: no leases property, that label.
  • Capacity bars say unknown — overview.ts:84-88, and the screen prints a
    dash and draws no share bar for it (a bar only shades a printed figure).
  • A reporting worker beside an unread one leaves the total unknown, and
    keeps its own figures — same test, second case.
  • Console lane green — the PR's Console job; the fleet fixture already
    waits out the starting window (e2e/console/fixtures.ts:209).

Deleting the isUnread guard reddens the test on its — assertion; deleting
the row's label or the bar guard reddens each named assertion.

Status

Implement: done (2/2 green) Review: round 1 (2 src fixed), round 2 F0, fix-check F0 Hardware: n/a Gate: merged (cb43a46)
Next: none

Assumptions

  • Assumption: whether a platform's share bar shows while its figures are unknown — the bar is left out. It only shades a number printed beside it (docs/internal/DESIGN.md), and an empty one reads as "nothing leased", the claim this bug is about.

Review

Spec review: 0 blocking, 2 fixed, 0 notes. Code review: 0 blocking, 1 fixed, 1 note. Claims review: 0 blocking, 0 fixed, 1 note.
Rounds: 2. Tokens: n/a.

Kind full, so all three reviews ran round 1, the code reviewer with lens: both. Three round-1 notes claimed wrong state or a rule breach, so each was verified: two were confirmed and fixed (the unknown tiles named a unit no test could pin, so the unit is omitted while unknown; an unread platform still drew an empty share bar), and one was a docs/CONSOLE.md line saying the dash appears "while it is starting" when a worker that disconnects while starting keeps its leases absent too (src/gateway/worker-registry.ts:422-441). Two src fixes took round 2 (code + claims), both F0; the comment-lint fix to the test's own comments took the fix check, also F0.

Rejected:

  • spec: ui/src/model/overview.test.ts:64 the new comments break the comment lint — CI's lint:comments is what rules on it; the lint then rejected six comments and that fix went through the fix check.

How the reviews were spawned: this session sits at subagent depth and the harness refused nested spawns, as on #643 and #644. Each reviewer ran as a fresh detached claude -p session — the body of .claude/agents/<reviewer>.md as its system prompt, its model from that file's frontmatter — reading only its review-inputs.sh directory and its own worktree of the reviewed commit, blind to this body, the commit messages and each other. Nothing was reviewed by the agent that wrote the code.

Written by an agent.

@V3RON

V3RON commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • code: ui/src/model/workers.ts:47 the devices === undefined half of isUnread keeps every test green when deleted (the gateway drops leases and devices together, so no view reports one without the other)
  • claims: ui/src/model/overview.test.ts:64 the comment cites ADR 0005 for "absent says not known"; that sentence is in src/gateway/worker-registry.ts:88-93 and Status answers only health and host while the daemon is starting #365's spec, not in the ADR's text

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 17, 2026 07:17
@V3RON
V3RON merged commit cb43a46 into main Oct 17, 2026
43 checks passed
@V3RON
V3RON deleted the bug/406 branch October 17, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console fleet totals count a starting worker's leases and devices as zero

1 participant