Repository navigation
Conversation
…rofile, not the one its name resolves to
…e resolves to 1 failing -> 0 failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #341
Status
Implement: done (1/1 green) Review: round 1 + fix check passed Hardware: n/a Gate: running
Next: gate result
catalogWithProfilesnow classes each model throughmatchProfile, the same resolutioncustomModelsandresolveuse; the triage test lands in this PR and passespnpm test:changed17 files / 1127 tests green locally, CI unit/timing/static greenBehavior change: a host whose
android.defaultModels.phonelist contains a namethat resolves to a TV or Wear OS profile (e.g.
tv_1080p) will stop granting itfor
phone-class leases and take the next candidate. That is the fix working,per the issue's Expected. Docs updated:
docs/CLI.mdand the android drivermanual state that a model's class follows the profile its name resolves to.
Assumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: n/a.
Fix check (code + claims) on the post-review commits: 0 blocking.
Fixed unreviewed (text-only):
Written by an agent.