Skip to content

fix(drivers/android): class a listed model by the profile its name resolves to - #646

Merged
V3RON merged 5 commits into
mainfrom
bug/341
Oct 16, 2026
Merged

V3RON merged 5 commits into
mainfrom
bug/341

Conversation

@V3RON

@V3RON V3RON commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #341

Status

Implement: done (1/1 green) Review: round 1 + fix check passed Hardware: n/a Gate: running
Next: gate result

  • A model's class in the catalog is the class of the profile a lease of that name creates — catalogWithProfiles now classes each model through matchProfile, the same resolution customModels and resolve use; the triage test lands in this PR and passes
  • Existing classification unchanged elsewhere — the android driver's unit files and the class-based readers' suites (leasing, gateway routing/aggregate/fleet, core catalog, CLI, MCP) stay green; pnpm test:changed 17 files / 1127 tests green locally, CI unit/timing/static green

Behavior change: a host whose android.defaultModels.phone list contains a name
that resolves to a TV or Wear OS profile (e.g. tv_1080p) will stop granting it
for phone-class leases and take the next candidate. That is the fix working,
per the issue's Expected. Docs updated: docs/CLI.md and the android driver
manual state that a model's class follows the profile its name resolves to.

Assumptions

none

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: n/a.

Fix check (code + claims) on the post-review commits: 0 blocking.

Fixed unreviewed (text-only):

  • claims: src/drivers/android/device-profile-source.test.ts:875 comment said each colliding name resolves to an SDK profile; two resolve to library profiles
  • CI: src/docs-manuals.test.ts manual line budget — the driver-manual line rewrapped into the Profiles paragraph

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 16, 2026 20:36
@V3RON
V3RON merged commit 5a7693b into main Oct 16, 2026
53 checks passed
@V3RON
V3RON deleted the bug/341 branch October 16, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An Android model's class comes from the listed profile, not the one its name resolves to

1 participant