Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #619
Status
Red stage: the spec's tests are written and fail on named assertions. No implementation beyond two optional option fields (
deviceCommand) so the tests compile.Done when
pnpm buildon this Mac (Xcode 27) puts both programs indist/bin/.e2e/slow-ios-stream.test.tspasses; the stream cases ine2e/slow-ios-physical.test.tspass on a real iPhone that meets the Physical iOS row's checks, the two new ones included; the lock case ine2e/slow-ios-physical-manual.test.tspasses with a person at the iPhone.GET /v1/stream/leases/{leaseId}for a physical iPhone no longer answers 415.Assumptions
dist/bin/simlock-device-captureis missing" — it is its own test ("the device capture program is built") rather than a guard insidedescribe.skipIf. Every other test in the file then fails on its own missing-program error too; an assertion in a test is the shape the suite already has for a broken build, and it keepsdescribe.skipIfabout the machine's fitness, not the checkout's.SIMLOCK_FAKE_SWIFT_FAILname list read by the test's own fakeswift. The fake is the test's own helper, so a variable of its own invents no surface; it is the smallest way to have one product build while the other does not.e2e/helpers/screen-frames.tsand re-exported from the helpers barrel, withslow-ios-stream.test.tsreading it from there. Sharing one copy keeps the two lanes' claim about "meta, an avcC description and a key frame" one claim (testing rule 7); the code itself is unchanged.This PR is stacked on #622 (
feature/617-adr): the ADR and its PoC, which this spec cites aspoc/, are on that branch.Written by an agent.