Skip to content

test(testkit): expect transitive dependencies of evaluated values - #1514

Closed
Anber wants to merge 1 commit into
masterfrom
anber/expect-transitive-eval-dependencies
Closed

Anber wants to merge 1 commit into
masterfrom
anber/expect-transitive-eval-dependencies

Conversation

@Anber

@Anber Anber commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

WyW now reports every module an evaluated value depends on in dependencies, not only the file's direct imports (wyw-in-js/wyw-in-js#463, not released yet). Direct imports keep their specifiers; modules reached through them are listed by resolved path; packages under node_modules are skipped.

  • 14 testkit metadata snapshots now list those modules. Only the Dependencies lines change; generated code and CSS are the same.
  • @linaria/core is a workspace package here, so it shows up behind @linaria/react as <repository>/packages/core/dist/index.js (normalized by test: make testkit results trustworthy across WyW updates #1513).

This stays a draft until a WyW release includes the change. The pinned @wyw-in-js/* 2.4.0 still reports direct imports only, so CI is expected to fail on these 14 snapshots until WyW is updated here; that update belongs in this PR once the release is out.

Tested with @wyw-in-js/* packed from wyw-in-js/wyw-in-js@55d9925c and installed into the workspace:

  • pnpm test with Turbo forced to run every task: 283 passed, 2 skipped; 316 snapshots passed.
  • pnpm check:all with the same WyW build linked: all tasks passed.

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 273f031

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

WyW now lists every module an evaluated value depends on, not only the
file's direct imports (wyw-in-js/wyw-in-js#463). Direct imports keep their
specifiers; modules reached through them are listed by resolved path,
and packages under node_modules are skipped. `@linaria/core` is a
workspace package here, so it appears behind `@linaria/react`.

Only the `Dependencies` lines change; generated code and CSS are the
same. WyW 2.4.0 still reports direct imports only, so these snapshots
belong with the WyW update that includes the change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Anber
Anber force-pushed the anber/expect-transitive-eval-dependencies branch from 3ee69e3 to 273f031 Compare October 10, 2026 19:56
@Anber

Anber commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by the pull request that updates the WyW dependencies to 2.7.0, so I am closing this one.

The 14 Dependencies: lines in babel.test.ts.snap only match on a WyW release that reports every module an evaluated value depends on, which @wyw-in-js/transform does from 2.6.0, and this branch still pins 2.4.0. The new pull request keeps this patch as its first commit (the same patch id, with a new commit message) and moves every @wyw-in-js/* pin from 2.4.0 to 2.7.0 in the commits after it, together with the lockfile and a changeset. It targets 2.7.0 rather than 2.6.0 because 2.7.0 is published and the same 14 lines pass on it without any other snapshot change. It mentions this pull request, so GitHub links the two.

@Anber Anber closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant