Repository navigation
build: raise the minimum Rust version to 1.91 (LAB-11169) - #137
Conversation
New releases support the latest stable Rust. rust-version moves from 1.85 to 1.91, the CI floor job moves with it, and the README states the policy: any release may raise rust-version when a dependency needs a newer toolchain, instead of holding that dependency back. 1.91 also lets clippy suggest is_multiple_of, so the one bench helper that computed it by hand uses the method now.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Declare and document the Rust version floor Cargo.toml, .github/workflows/ci.yml, README.md |
Cargo.toml sets Rust 1.91 as the minimum. The CI matrix aligns with that version, and the README describes the minimum and future version policy. |
Benchmark expression
| Layer / File(s) | Summary |
|---|---|
Update active-value expression benches/common/mod.rs |
The active calculation uses is_multiple_of(3) instead of a remainder comparison. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- cachekit-io/cachekit-core#136: Both PRs address the Rust MSRV constraint on dependency updates.
Suggested reviewers: kodus-27b
Merge Risk: 
526c1
-
No concrete merge-blocking risk remains in the reviewed changes.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: raising the minimum Rust version to 1.91. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The pull request description clearly matches the changes. It explains the Rust version increase, CI updates, README updates, benchmark change, validation results, and required branch-rule rename. Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kodus-27b[bot]](https://avatars.githubusercontent.com/u/223823690?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The floor job's name carried the toolchain version, and it is a required check, so every floor raise would also need a branch rule change. A matrix label keeps the name at "msrv / ubuntu-latest"; the clippy and component conditions key on the label too, so the version is written in one place in this file.
a08181d
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Raises
rust-versionfrom 1.85 to 1.91 and adopts a support-stable policy: new releases support the latest stable Rust, and any release may raiserust-versionwhen a dependency needs a newer toolchain, instead of holding that dependency back.1.85 was never a support promise. It was the edition 2024 floor that a build dependency forced on the crate. It had started blocking routine updates: proptest 1.12 needs 1.88, aes 0.9.3 needs 1.89 and sha2 0.11.1 needs 1.88.
Changes
Cargo.toml:rust-version = "1.91".ci.yml: the floor row of the test matrix runs 1.91, with a comment stating the policy.README.md: MSRV badge and section.benches/common/mod.rs: at the new msrv, clippy'smanual_is_multiple_offires on one bench helper, so it usesis_multiple_of.Verified locally
cargo +1.91 test --all-features: 250 passed, 0 failed.cargo clippy --all-features --all-targets -- -D warnings,cargo clippy --features encryption --all-targets -- -D warningsandcargo fmt --checkall pass.Required check rename. The floor job is now named
msrv / ubuntu-latest(a matrix label), so later raises change no branch rule. The branch rules still require1.85 / ubuntu-latest, which no longer reports: replace it withmsrv / ubuntu-latestbefore merging. Open PRs based on an oldermainreport the new name once they mergemain.