Repository navigation
fix(deps): update cachekit-rs to 0.11.1 and drop the cbindgen licence exception (LAB-7740) - #23
Conversation
cachekit-core 0.7 builds cbindgen only under its ffi feature, which ck does not enable, so cbindgen leaves the dependency graph and deny.toml no longer needs its MPL-2.0 exception. cachekit-rs 0.11.1 is the first release on cachekit-core 0.7; 0.11.0 still pulls 0.6, so the requirement names 0.11.1.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
Kody Code Review — 1 suggested fix. 🛠️ Open Agent Prompt |
Ban a second cachekit-core version, so key derivation and the EncryptionLayer cannot come from different releases. Add known-answer tests for the cache key and for decrypting an entry written by cachekit-rs 0.9.0 on cachekit-core 0.6.0. Drop the stale client timeout figures from the SAAS_DEADLINE comment.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Updates cachekit-rs 0.9 → 0.11.1 and cachekit-core 0.6 → 0.7, and removes the crate-scoped
cbindgen(MPL-2.0) licence exception fromdeny.toml.cachekit-core 0.7 builds cbindgen only under its
ffifeature, which ck does not enable. cachekit-rs 0.11.1 is the first release on cachekit-core 0.7 (0.11.0 still requires^0.6), so the requirement names0.11.1: a looser0.11would let a resolver pick 0.11.0 and pull a second cachekit-core, and cbindgen with it.Compatibility. ck uses
EncryptionLayerand the file and cachekitio backends directly, not the high-level client. Between 0.9.0 and 0.11.1,EncryptionLayer's API and AAD are unchanged (doc comments only), and the file backend's entry format is unchanged (new protocol vectors, same writer). The 0.10 breaking changes (namespace-bound AAD, encrypt-everything) are in the high-level client, which ck does not use. Existing ck cache entries stay readable. cachekit-core 0.7's breaking change removes the metrics API, which ck does not use.Checks run locally:
cargo tree --locked -e build -i cbindgen: no matchcargo deny check: advisories, bans, licences and sources okcargo fmt --check,cargo clippy --locked --all-targets -- -D warningscargo test --locked: all pass--release --test bench -- --ignored): within budgetcargo +1.85 check --locked --all-targetsGuards for the next bump:
deny.tomlbans a secondcachekit-coreversion (deny-multiple-versions), so ck's key derivation (cachekit-core) and itsEncryptionLayer(cachekit-rs) cannot come from different releases. Checked: withcachekit-core = "0.6"the bans check fails on the duplicate.keys::tests::value_key_known_answerpins the cache key for a fixed master key, andstore::tests::an_older_entry_still_decryptsdecrypts a ciphertext written by cachekit-rs 0.9.0 on cachekit-core 0.6.0. A derivation or format drift now fails a test, instead of turning every stored entry into a silent miss.Docs: the
SAAS_DEADLINEcomment insrc/store.rsquoted the 0.9 client's timeouts. It no longer quotes figures. No README or doc text names cbindgen or these dependency versions.Closes LAB-7740