Repository navigation
Use 32-bit UID/GID syscalls on arm, sparc, and x86 - #1716
Merged
sunfishcode merged 1 commit intoOct 26, 2026
Merged
Conversation
On 32-bit Linux arm, sparc, and x86, the unsuffixed getgroups, setgroups, setuid, setgid, chown, and fchown syscalls take 16-bit UIDs and GIDs, while rustix uses 32-bit Uid and Gid values. Calling the 16-bit syscalls truncates UIDs and GIDs at 65536 and causes getgroups and setgroups_thread to read and write pairs of 16-bit GIDs in each 32-bit Gid slot. Use the *32 syscall variants for getgroups, setuid_thread, setgid_thread, setgroups_thread, chown, and fchown on arm, sparc, and x86 in both the linux_raw and libc backends, matching getuid and setresuid_thread. Add a getgroups test comparing against libc.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit Linux arm, sparc, and x86, the unsuffixed getgroups, setgroups, setuid, setgid, chown, and fchown syscalls take 16-bit UIDs and GIDs, while rustix uses 32-bit Uid and Gid values.
Calling the 16-bit syscalls truncates UIDs and GIDs at 65536 and causes getgroups and setgroups_thread to read and write pairs of 16-bit GIDs in each 32-bit Gid slot.
Use the *32 syscall variants for getgroups, setuid_thread, setgid_thread, setgroups_thread, chown, and fchown on arm, sparc, and x86 in both the linux_raw and libc backends, matching getuid and setresuid_thread.
Add a getgroups test comparing against libc.