Repository navigation
Header policy: catch the parser's real exception - #340
Open
Ghesselink wants to merge 2 commits into
Open
Ghesselink wants to merge 2 commits into
Ghesselink wants to merge 2 commits into
Conversation
Ghesselink
changed the title
aothms
approved these changes
Oct 30, 2026
| file = ifcopenshell.simple_spf.open(filename, only_header=True) | ||
| header = HeaderStructure(file=file) | ||
| except ifcopenshell.simple_spf.SyntaxError: | ||
| except ifcopenshell.simple_spf.CollectedValidationErrors: |
Collaborator
There was a problem hiding this comment.
Not very pretty. Maybe we should adapt the submodule so that CollectedValidationErrors inherits from SyntaxError or some other abstract exception. It feels a bit leaky to really catch something so specific. Otherwise it sounds like it should not be an exception at all, but more like a report that is returned. See if you feel like it. Not really important enough to justify a lot of work.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup:
validate_header.py catches ifcopenshell.simple_spf.SyntaxError, which does not exist; the parser raises
CollectedValidationErrors. So whenever the try block fails, the script dies with anAttributeErrorinsteadof returning the intended {"validation_errors": ["syntax_error"]}.
Impact is small: the header-syntax task runs first and skips the header task on an unparsable header, so
in the pipeline this path is not reached.