Repository navigation
fix(xdebug): exception breakpoint examples name a class, not Throwable - #405
Merged
Merged
Conversation
Xdebug matches an exception breakpoint on the thrown class and its parent classes, never on interfaces: "Throwable" is accepted and never fires. The MCP schema hint, doc comment and error text now show RuntimeException and "*" and say interfaces do not match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Text-only follow-up to #403. Xdebug matches an exception breakpoint on the thrown class and its parent classes, not on interfaces, so
-x Throwableis accepted and never fires. The examples in the MCPxdebug_breakpoint_setschema hint, theSavedBreakpoint.Exceptiondoc comment and thenormalize()error text now showRuntimeException,App\Exceptions\PaymentFailedand*, and say interfaces do not match. No behaviour change.Checked
RuntimeException:-x Throwable→runendsstopping;-x Exception→break;-x *→break.go vet ./modules/xdebug/clean;go test -count=1 ./modules/xdebug/ok.Made with harnsy