Repository navigation
fix(ray): merge guards — deleted event, other project, size cap - #400
Merged
Merged
Conversation
Review notes on #396: a follow-up whose event was deleted between the lookup and the update is stored as a new event instead of re-broadcasting a deleted one; an event of another project with the same uuid is never changed; a Ray event takes at most 1000 payloads / 8 MB, further follow-ups are dropped with a warning (each one rewrites and re-broadcasts the whole event). Refs #345
butschster
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #396 (review notes), refs #345.
Changes
Store.UpdatePayloadreturnsevent.ErrNotFoundwhen no row was updated. A follow-up whose event was deleted between the lookup and the update is stored as a new event, instead of re-broadcasting a deleted event (ghost in the UI) and losing the follow-up.Tests
go test -race ./modules/ray/ ./internal/server/http/ ./internal/storage/ ./internal/metrics/ ./internal/event/; newTestRay_FollowUpOfDeletedEvent,TestRay_FollowUpOtherProject,TestRay_MergeLimit,TestSQLiteStore_UpdatePayloadMissing.Made with harnsy