Repository navigation
fix: tightest memory limit of the cgroup and its parents; no log for GOMEMLIMIT=off - #399
Merged
Merged
Conversation
…GOMEMLIMIT=off Review notes on #398: a process whose own cgroup has no limit under a limited slice now gets the slice's limit (every level up to the root counts, the smallest wins); the v1 limit is read from the process's own memory cgroup too; GOMEMLIMIT=off no longer logs a bogus 8 EiB limit. Refs #331
butschster
added
performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #398 (review notes), refs #331.
Changes
/init.scope) now gets the slice's limit.N:memory:/pathin/proc/self/cgroup) and its parents is read, not only the root's. v2 still comes first.GOMEMLIMIT=offno longer logsgo memory limit mib=8796093022207; nothing is logged.Tests
go test -run "Memory|SelfCgroup" ./internal/app/: new table casesv2 limited parent,v2 smallest wins,v1 own cgroup;TestSelfCgroupcovers hybrid and v1-only;TestApplyMemoryLimit_EnvWinschecksoff.Live:
systemd-run --user --scope -p MemoryMax=512M ./buggregator→mib=460 source=cgroup;GOMEMLIMIT=off→ no log line.Made with harnsy