Repository navigation
build(deps): bump social-auth-core to 5.0.2 (CTO-5452) #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ MarkupSafe==2.1.5 | |
| msgpack==1.2.1 | ||
| ndg-httpsclient==0.5.1 | ||
| oauth2client==4.1.3 | ||
| oauthlib==3.1.0 | ||
| oauthlib==3.3.1 | ||
| packaging==24.2 | ||
| paramiko==3.4.0 | ||
| parso==0.7.1 | ||
|
|
@@ -72,14 +72,14 @@ pytz==2021.3 | |
| pyvim==3.0.2 | ||
| pyvmomi==7.0.1 | ||
| PyYAML==6.0.2 | ||
| requests==2.33.0 | ||
| requests-oauthlib==1.3.0 | ||
| requests==2.34.2 | ||
| requests-oauthlib==2.0.0 | ||
| rsa==4.7 | ||
| scandir==1.10.0 | ||
| simplegeneric==0.8.1 | ||
| six==1.15.0 | ||
| social-auth-app-django==5.4.1 | ||
| social-auth-core==4.5.4 | ||
| social-auth-core==5.0.2 | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Medium] Pairing with social-auth-app-django 5.4.1 is not an upstream-released combination Core tightened OAuth2 state/redirect handling and added request timeouts since 4.5.4. The mocked SSO run (passes on 3.11 and 3.12) cannot exercise live Google. Suggestion: one real Google login on staging before prod. Reviewer: code-review |
||
| soupsieve==2.8.4 | ||
| sqlparse==0.6.0 | ||
| traitlets==5.0.5 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Medium] oauthlib 3.3.1 leaves alerts #200 and #201 open
GHSA-hj66-6f7g-4r5v and GHSA-xpv3-w29h-x7cv are fixed only in 4.0.0. Nothing in the tree caps oauthlib below 4 (social-auth-core needs
>=3.3.1, requests-oauthlib>=3.0.0). Both are provider-side endpoints enigma does not serve.Suggestion:
oauthlib==4.0.0here after a changelog check, or an immediate follow-up.Reviewer: code-review