Skip to content

Only GLOB headers when generating Visual Studio projects - #1217

Open
cdglove wants to merge 1 commit into
boostorg:developfrom
cdglove:develop
Open

cdglove wants to merge 1 commit into
boostorg:developfrom
cdglove:develop

Conversation

@cdglove

@cdglove cdglove commented Oct 30, 2026

Copy link
Copy Markdown

When file(GLOB ... CONFIGURE_DEPENDS) or file(GLOB_RECURSE ... CONFIGURE_DEPENDS) is evaluated, CMake's make style generators create a verification script (VerifyGlobs.cmake) that gets run on every build, outputting "Re-checking globbed directories....". This can cause a a noticeable delay on incremental builds.

Since the headers are only needed for IDE project navigation, limiting this check to that use case is a good compromise.

@cppalliance-bot

cppalliance-bot commented Oct 30, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://1217.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-31 22:14:07 UTC

@cppalliance-bot

cppalliance-bot commented Oct 30, 2026 •

Copy link
Copy Markdown

GCOVR code coverage report https://1217.json.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://1217.json.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff Report https://1217.json.prtest2.cppalliance.org/diff-report/index.html

Build time: 2026-10-31 22:43:11 UTC

@cppalliance-bot

Copy link
Copy Markdown

@grisumbras

Copy link
Copy Markdown
Member

How much time does globbing really take for Json? I checked CI logs and it's less than a second for our Windows jobs.

@cdglove

cdglove commented Oct 30, 2026

Copy link
Copy Markdown
Author

How much time does globbing really take for Json? I checked CI logs and it's less than a second for our Windows jobs.

I don't know, I didn't measure this library specifically. I found this problem with 6 individual libraries that were cumulatively adding a multi second stall to my build and changed them all at once.

See my corresponding post to the mailing list:
https://lists.boost.org/archives/list/boost@lists.boost.org/thread/LKPFNC3AMPIVWRAE75EFMYRMS6AL6MV4/

@sehe

sehe commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

I asked a question about the validity of the reasoning here boostorg/assert#49 (comment)

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.97%. Comparing base (349862a) to head (c47a425).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1217   +/-   ##
========================================
  Coverage    93.97%   93.97%           
========================================
  Files           85       85           
  Lines         8970     8970           
========================================
  Hits          8430     8430           
  Misses         540      540           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349862a...c47a425. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Allows projects building boost via add_subdirectory to avoid the cost
of GLOB on every build.
@cppalliance-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants