Repository navigation
Make the space-optimized adaptor header self-contained - #55
Open
trestoncuzzort wants to merge 1 commit into
Open
trestoncuzzort wants to merge 1 commit into
trestoncuzzort wants to merge 1 commit into
Conversation
Include the main header before the adaptor guard so its internal macros remain defined while the adaptor is parsed. Include the adaptor header first in the existing test to cover standalone inclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48.
Including only
<boost/circular_buffer/space_optimized.hpp>fails because the adaptor's base class and configuration are not available. Include the main header before the adaptor's include guard. The placement lets the main header include the adaptor while its internal macros are still defined, before it undefines them at the end.Make the existing adaptor test include this header first, with the existing test hooks enabled. That test fails to compile against the original headers.
Validation:
-Wall -Wextra -Werror, covering all six permutations of the forward/main/adaptor headers, direct and repeated inclusion, both language modes and both debug settings.-Wall -Wextra -Werror.git diff --checkpasses. Windows was not run locally.OpenAI Codex assisted with investigation, implementation and verification.