Skip to content

add checkboom (attempt 2) - #503

Merged
Loup-Garou911XD merged 9 commits into
bombsquad-community:mainfrom
BroBordd:main
Nov 1, 2026
Merged

Loup-Garou911XD merged 9 commits into
bombsquad-community:mainfrom
BroBordd:main

Conversation

@BroBordd

Copy link
Copy Markdown
Collaborator

i discarded commits to make repo identical to latest
since i dont know what branches are

@Loup-Garou911XD

Copy link
Copy Markdown
Member

still getting this error

0.135 INFO ba.app: BallisticaKit 1.8.3 build 23065 starting...
10.644 ERROR ba.assets: Unable to load texture: 'reflectionSharper_-z'.
17.492 ERROR root: Error in on_player_join for <checkboom.Checkboom object at 0x7f7fec95fb60>.
Traceback (most recent call last):
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_activity.py", line 540, in add_player
    self.on_player_join(player)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/loup/.var/app/net.froemling.bombsquad/.ballisticakit/mods/checkboom.py", line 825, in on_player_join
    super().on_player_join(player)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_gameactivity.py", line 725, in on_player_join
    self.spawn_player(player)
    ~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_gameactivity.py", line 1134, in spawn_player
    return self.spawn_player_spaz(player)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_teamgame.py", line 130, in spawn_player_spaz
    return super().spawn_player_spaz(player, position, angle)
           ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_gameactivity.py", line 1158, in spawn_player_spaz
    spaz = playerspaztype(
        color=color,
    ...<3 lines>...
        player=player,
    )
  File "/app/bin/bombsquad/ba_data/python/bascenev1lib/actor/playerspaz.py", line 109, in __init__
    super().__init__(
    ~~~~~~~~~~~~~~~~^
        color=color,
        ^^^^^^^^^^^^
    ...<5 lines>...
        powerups_expire=powerups_expire,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
TypeError: __init__() got an unexpected keyword argument 'cloud_spaz_def'
17.494 ERROR root: Error in bascenev1.Actor.__del__() for <bascenev1lib.actor.playerspaz.PlayerSpaz object at 0x7f7fec95fe00>.
Traceback (most recent call last):
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_actor.py", line 107, in __del__
    if not self.expired:
           ^^^^^^^^^^^^
  File "/app/bin/bombsquad/ba_data/python/bascenev1/_actor.py", line 164, in expired
    host = None if self._host is None else self._host()
                   ^^^^^^^^^^
AttributeError: 'PlayerSpaz' object has no attribute '_host'

@BroBordd

Copy link
Copy Markdown
Collaborator Author

i shouldn't have used these dirty workarounds

@BroBordd

Copy link
Copy Markdown
Collaborator Author

let's see what i can do now

@BroBordd

Copy link
Copy Markdown
Collaborator Author

the _host error you mentioned, when does it appear?

@BroBordd

Copy link
Copy Markdown
Collaborator Author

I'm on 1.8.1 and on_player_join is functioning normally

@Loup-Garou911XD

Copy link
Copy Markdown
Member

the _host error you mentioned, when does it appear?

When I launch teams playlist with this minigame

@BroBordd

Copy link
Copy Markdown
Collaborator Author

the _host error you mentioned, when does it appear?

When I launch teams playlist with this minigame

that's how i play it too

  • are you on a newer version than 1.8.1
  • did you try the latest file because i finished all the fixes

@BroBordd

Copy link
Copy Markdown
Collaborator Author

asking because your traceback signals a fault outside my reach

@Loup-Garou911XD

Copy link
Copy Markdown
Member

the _host error you mentioned, when does it appear?

When I launch teams playlist with this minigame

that's how i play it too

  • are you on a newer version than 1.8.1
  • did you try the latest file because i finished all the fixes

1.8.3 i think

@BroBordd

Copy link
Copy Markdown
Collaborator Author

this raises a question, do vanilla team games even work on your side

@BroBordd

Copy link
Copy Markdown
Collaborator Author

because all i do is call super().on_player_join

@Loup-Garou911XD

Copy link
Copy Markdown
Member

i also just added __doc__ support to the description field
Check https://github.com/bombsquad-community/plugin-manager#the-plugman-dict
But you would have to cleanup the module docstring if you want to use that

- Checkboom v1.0.0 - Boom goes the king

@BroBordd

Copy link
Copy Markdown
Collaborator Author

i also just added __doc__ support to the description field Check https://github.com/bombsquad-community/plugin-manager#the-plugman-dict But you would have to cleanup the module docstring if you want to use that

- Checkboom v1.0.0 - Boom goes the king

i would like to, but this plugin follows a static syntax you'll find in all of my plugins

@BroBordd

Copy link
Copy Markdown
Collaborator Author

and there is a difference between these, one is a short description, one is a long description, and one is a clear description for plugman

@Loup-Garou911XD

Loup-Garou911XD commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

i also just added __doc__ support to the description field Check https://github.com/bombsquad-community/plugin-manager#the-plugman-dict But you would have to cleanup the module docstring if you want to use that

- Checkboom v1.0.0 - Boom goes the king

i would like to, but this plugin follows a static syntax you'll find in all of my plugins

whatever you prefer, just letting you know its an option now

@Loup-Garou911XD
Loup-Garou911XD marked this pull request as draft October 27, 2026 05:44
@Loup-Garou911XD

Copy link
Copy Markdown
Member

@BroBordd
I converted this to a draft, mark it ready when its done

@BroBordd

Copy link
Copy Markdown
Collaborator Author

@BroBordd I converted this to a draft, mark it ready when its done

done with what

@BroBordd

Copy link
Copy Markdown
Collaborator Author

i mentioned checkboom was finished

@BroBordd

Copy link
Copy Markdown
Collaborator Author

another bug fixed

@BroBordd

Copy link
Copy Markdown
Collaborator Author

who knows what else is hiding

@Loup-Garou911XD
Loup-Garou911XD marked this pull request as ready for review October 29, 2026 07:05
Updated the description and external URL for recent party names log plugin.
@Loup-Garou911XD
Loup-Garou911XD merged commit 2969852 into bombsquad-community:main Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants