Repository navigation
Conversation
A diff -u of two different files was parsed as the new path only. Patches that are only --- and +++ still use the existing name heuristic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
diff -u old newpatch stored both paths as the new file.Parsethen reported one path instead of a change from the old file to the new file. When the patch starts with a diff command that names two files, both paths are kept. Patches that are only---and+++still use the existing one-name heuristic, including backup names such asfileandfile~.The parser looks one line further ahead so that command can see the fragment header the same way a traditional header does.
Fixes #65
Test plan
TestParseDiffCommandKeepsDistinctNamesfailed before the change (both names were the new path) and passes after itgo test ./...golangci-lint run ./...