Repository navigation
fix: distrust compromised eMudhra intermediates - #414
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The private keys of eight eMudhra intermediate CAs are recoverable from their public certificates, so a client trusting the chain can be MITM'd (https://emudhra.we-have-a-problem.com/). Upgrade Go to 1.26.10, a patched release, and require Alpine `ca-certificates>=20261020-r0` in the runtime image. The version constraint fails the build rather than shipping old roots, and busts any cached layer from before the fix. Constraint: Stay on the Go 1.26 line rather than moving to 1.27.3 Rejected: Remove roots manually from /etc/ca-certificates.conf | patched Alpine package exists Confidence: high Scope-risk: narrow Not-tested: Full cachew image build (needs dist/ binaries) Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
sylr
force-pushed
the
fix/emudhra-compromised-cas
branch
from
October 21, 2026 08:44
cf83671 to
da40c79
Compare
alecthomas
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private keys of eight eMudhra intermediate CAs can be recovered from their public certificates. Any client that still trusts these chains can be MITM'd. See https://emudhra.we-have-a-problem.com/.
This change:
ca-certificates>=20261020-r0indocker/Dockerfile. Alpine 3.23 already ships this version. The constraint fails the build rather than shipping old roots, and it busts any cached layer from before the fix.Tests:
alpine:3.23image with the sameapk addline. It installedca-certificates-20261020-r0.curltodv-g3b-emudhra.we-have-a-problem.comanddv-g3b-aaa-emudhra.we-have-a-problem.comfails with "unable to get local issuer certificate", so the compromised chains are rejected.go build ./...and the test suite pass on 1.26.10. The exception isgitcloneTestRepository_HasCommit, which fails the same way on 1.26.1. The likely cause is a localtag.gpgsign=truesetting, not this change.dist/binaries.