Repository navigation
docs(reachability): name the pkc-js version from which browsers dial WebTransport - #247
Conversation
…WebTransport Browser clients dial WebTransport from pkc-js 0.0.139 on (pkcprotocol/pkc-js#492); older ones dial WebSocket Secure only. The README, docs/reachability.md and the setup warning shown when no WSS address works now say so instead of "for browsers that support it".
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Closes #246. Follow-up to #219.
Summary
pkc-js 0.0.139 makes browser clients dial WebTransport as well as WebSocket Secure (pkcprotocol/pkc-js#492, part of pkcprotocol/pkc-js#475). Browser clients built on an older pkc-js dial WebSocket Secure only. The reachability text now names that version where it used to say "for browsers that support it" or nothing at all.
README.md, "Making your node reachable from browsers"docs/reachability.md, "WebTransport and AutoNAT"src/reachability/guidance.ts,noWssStatementtest/reachability/setup.test.tsWording only. Listeners, setup, the status verdicts and the daemon are untouched.
Evidence
npm run build && npm run build:testpass.npm run test:cli -- test/reachability: 11 files, 611 tests pass. The full suite was left to CI.Door: two-way. Blast Radius: docs and one warning message.